Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of uints from IHederaTokenService precompile selectors #3916

Closed
Nana-EC opened this issue Sep 9, 2022 · 0 comments · Fixed by #4067 or hashgraph/hedera-smart-contracts#151
Closed

Remove use of uints from IHederaTokenService precompile selectors #3916

Nana-EC opened this issue Sep 9, 2022 · 0 comments · Fixed by #4067 or hashgraph/hedera-smart-contracts#151
Assignees
@georg-getz
Labels
Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service. Limechain Work planned for the LimeChain team P2 Required to be completed in the assigned milestone, but may or may not impact the release schedule.

Comments

@Nana-EC
Copy link
Contributor

Nana-EC commented Sep 9, 2022

Problem

IHederaTokenService precompile selectors utilize some uints

Solution

Update IHederaTokenService precompile selectors to utilize signed integers instead of unsigned to match java

Note: this may require some protobuf, solidity and documentation updates

Alternatives

No response
@Nana-EC Nana-EC added the Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service. label Sep 9, 2022
@Nana-EC Nana-EC mentioned this issue Sep 9, 2022
Closed
@Nana-EC Nana-EC added the P2 Required to be completed in the assigned milestone, but may or may not impact the release schedule. label Sep 20, 2022
@Nana-EC Nana-EC added this to the v0.31.0 milestone Sep 20, 2022
@Nana-EC Nana-EC added the Limechain Work planned for the LimeChain team label Sep 20, 2022
This was referenced Sep 27, 2022
Closed
Closed
@Kalina-Todorova Kalina-Todorova removed this from the v0.31.0 milestone Sep 29, 2022
@Nana-EC Nana-EC mentioned this issue Oct 3, 2022
Closed
@georg-getz georg-getz mentioned this issue Oct 13, 2022
Closed
2 tasks
@Kalina-Todorova Kalina-Todorova linked a pull request Oct 28, 2022 that will close this issue
added the new function hashes and updated the precompiles and tests #4067
Merged
2 tasks
@georg-getz georg-getz mentioned this issue Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georg-getz georg-getz

Labels
Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service. Limechain Work planned for the LimeChain team P2 Required to be completed in the assigned milestone, but may or may not impact the release schedule.
Projects
Smart Contract Sprint Board
Archived in project
Milestone
No milestone
3 participants
@georg-getz @Nana-EC @Kalina-Todorova