removed instances of non-deprecated uints being used #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Georgi Georgiev <georgi.getz@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Georgi Georgiev georgi.getz@outlook.com
Description:
This PR is the first of several to be parallelly merged fixing the misalignment of types between the protobuf files and the contracts and it also includes replacement of all uints in the protobuf files. The reason the uints are a problem is because they are ultimately being converted to a signed type regardless and the upper half of their values is unusable.
Part of the work in the other repos depends on feedback given to this PR.
Related issue(s):
Fixes hashgraph/hedera-services#3921
hashgraph/hedera-services#3916
Notes for reviewer:
This PR won't be merged until the necessary follow-up PRs in the contracts/docs/services/sdk repos have all been opened and approved as well.
Checklist