update token create and token update precompile selectors to match documentation/protobuf #3910
Conversation
…cumentation/protobuf Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Codecov Report
@@ Coverage Diff @@
## master #3910 +/- ##
=============================================
+ Coverage 85.19% 96.62% +11.43%
- Complexity 12889 14032 +1143
=============================================
Files 945 941 -4
Lines 45850 40497 -5353
Branches 4906 4097 -809
=============================================
+ Hits 39061 39132 +71
+ Misses 6102 677 -5425
- Partials 687 688 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
|
Kudos, SonarCloud Quality Gate passed! |
|
Hi, if the problem was that field types weren't correct and didn't match protobuf/docs is there a good reason for backwards compatibility? Isn't it better to outright delete the older version? |
Dev experience. |
| @@ -131,20 +133,38 @@ private AbiConstants() { | |||
| // **** HIP-358 function selectors **** | |||
| // createFungibleToken(HederaToken memory token, uint initialTotalSupply, uint decimals) | |||
| public static final int ABI_ID_CREATE_FUNGIBLE_TOKEN = 0x7812a04b; | |||
| // createFungibleToken(HederaToken memory token, uint64 initialTotalSupply, uint32 decimals) | |||
| public static final int ABI_ID_CREATE_FUNGIBLE_TOKEN_V2 = 0xc23baeb6; | |||
There was a problem hiding this comment.
nit: I like the callout comment you did on the others so suggesting this
| public static final int ABI_ID_CREATE_FUNGIBLE_TOKEN_V2 = 0xc23baeb6; | |
| // decimals updated to uint32 | |
| public static final int ABI_ID_CREATE_FUNGIBLE_TOKEN_V2 = 0xc23baeb6; |
Signed-off-by: lukelee-sl luke.lee@swirldslabs.com
Description:
Some of the types in structs and call parameters for creating and updating tokens did not match documentation and/or protobuf specs. The Hedera-smart-contract repo has been updated with the correct types and this pull request addresses the necessary changes on the services side.
For backwards compatibility, the existing selectors were left in place and new selectors were added to DecodingFacade to support the new signatures.
Related issue(s):
Fixes #3902
Based on hashgraph/hedera-smart-contracts#56
Notes for reviewer:
Checklist