-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CryptoCreate
handle method
#6112
Implement CryptoCreate
handle method
#6112
Conversation
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
…otobuf Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
...-node/hapi-fees/src/main/java/com/hedera/node/app/hapi/fees/usage/crypto/CryptoOpsUsage.java
Outdated
Show resolved
Hide resolved
...-service-impl/src/main/java/com/hedera/node/app/service/token/impl/WritableAccountStore.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
...-service-impl/src/main/java/com/hedera/node/app/service/token/impl/WritableAccountStore.java
Outdated
Show resolved
Hide resolved
...-impl/src/main/java/com/hedera/node/app/service/token/impl/handlers/CryptoCreateHandler.java
Outdated
Show resolved
Hide resolved
...-impl/src/main/java/com/hedera/node/app/service/token/impl/handlers/CryptoCreateHandler.java
Show resolved
Hide resolved
...-node/hapi-fees/src/main/java/com/hedera/node/app/hapi/fees/usage/crypto/CryptoOpsUsage.java
Outdated
Show resolved
Hide resolved
.../test/java/com/hedera/node/app/service/token/impl/test/handlers/CryptoCreateHandlerTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ty @Neeharika-Sompalli !
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Neeharika-Sompalli, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from a release engineering perspective I approve the build changes, please wait for other approvers for remaining code before merging.
SonarCloud Quality Gate failed. |
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com> Signed-off-by: Matt Hess <matt.hess@swirldslabs.com> # Conflicts: # hedera-node/hedera-token-service-impl/src/test/java/module-info.java
Fixes #6038
Fixes #6113
Depends on hashgraph/hedera-protobufs#270 these protobuf changes
WritableAccountStore
CryptoCreate
handle implementationpureChecks
method to validate only transaction body fields that doesn't involve dynamic properties or state