package: fix relative paths and embedded composite actions #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryancragun
force-pushed
the
ryan/dont-clobber-caller-checkout-dir
branch
from
df76c28
to
27fd731
Compare
Fix several small issues that make it possible to migrate from the prior Docker based version to the composite action version * Check out the action repo into a different directory when building nfpm * Execute nfpm from the root workspace directory to support relative paths in configs * Work around runners bugs when executing composite actions inside the scope of other composite actions. Signed-off-by: Ryan Cragun <me@ryan.ec>
ryancragun
force-pushed
the
ryan/dont-clobber-caller-checkout-dir
branch
from
dd0c28d
to
f8956bc
Compare
ryancragun
changed the title
|
Tested this branch in Vault here: https://github.com/hashicorp/vault/actions/runs/9023783620/job/24796306015?pr=26905 |
shore
approved these changes
May 9, 2024
action.yml
Outdated
Comment on lines
222
to
225
| if ! nfpm package -f "$config_file" -p ${1} -t ./out/; then | ||
| printf "failed to create package with nfpm for $1 using config $(cat $config_file)\n" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Nit: I don't think it's helpful to dump the config file a second time, but I do think it's helpful to always dump it. Maybe remove the conditional and let nfpm's non-zero exit directly halt the script and job?
There was a problem hiding this comment.
I think that was an artifact of me debugging and I missed taking it out!
Signed-off-by: Ryan Cragun <me@ryan.ec>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix several small issues that make it possible to migrate from the prior
Docker based version to the composite action version
paths in configs
scope of other composite actions.