Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always Enable Shared Configuration File Support #35

Closed
bflad opened this issue Jun 2, 2020 · 0 comments · Fixed by #38
Closed

Always Enable Shared Configuration File Support #35

bflad opened this issue Jun 2, 2020 · 0 comments · Fixed by #38
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Jun 2, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

A confusing aspect of working with the Terraform S3 Backend and Terraform AWS Provider is that the underlying AWS Go SDK v1 does not automatically enable the shared configuration file (e.g. ~/.aws/config) by default like the AWS CLI and other SDKs. Enabling it requires a lesser documented environment variable: AWS_SDK_LOAD_CONFIG=1 as a workaround. While we are introducing potentially breaking changes, we will enable this support by default to reduce confusion.

Potential Library Implementation

In all relevant places:

(*session.Options).SharedConfigState = session.SharedConfigEnable

Potential Terraform Backend/Provider Configuration

No changes required. :)

References

@bflad bflad added the enhancement New feature or request label Jun 2, 2020
@bflad bflad added this to the v0.5.0 milestone Jun 2, 2020
@bflad bflad self-assigned this Jun 2, 2020
bflad added a commit that referenced this issue Jun 2, 2020
@bflad bflad closed this as completed in #38 Jun 3, 2020
bflad added a commit that referenced this issue Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant