Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix datadog tests #115

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Fix datadog tests #115

merged 1 commit into from
Sep 9, 2020

Conversation

dnephin
Copy link
Contributor

@dnephin dnephin commented Aug 31, 2020 •
edited
Loading

Fixes the datadog tests for the new expected value. The upgrade of github.com/DataDog/datadog-go in #100 caused the value of gauge metrics to change.

@dnephin dnephin mentioned this pull request Aug 31, 2020
Merged
@dnephin
Fix datadog test failures
92a35b7 
The upgrade of github.com/DataDog/datadog-go in hashicorp#100
caused the vault of gauge metrics to change.
@dnephin
Copy link
Contributor Author

dnephin commented Sep 1, 2020

@jefferai I believe the expected values changed with your PR #100. Does this look right to you? You can see the tests passing in #116

@dnephin
Copy link
Contributor Author

dnephin commented Sep 8, 2020

cc @banks @armon

The go-metrics tests fail on master. This PR should fix the failures. Does this look right to you?

#116 adds CI config to prevent this from happening in the future.

banks
banks approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't know why the precision of the output changed but I don't think it matters for statsd so better that the tests pass!

Thanks!

@banks
Copy link
Member

banks commented Sep 9, 2020

Oh I see, it was the DD import upgrade.

@banks banks merged commit a726270 into hashicorp:master Sep 9, 2020
@dnephin dnephin deleted the fix-datadog-tests branch September 10, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banks banks banks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnephin @banks