Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releases: Add benchmark for ExectVersion.Install() #134

Merged
merged 1 commit into from
May 11, 2023
Merged

releases: Add benchmark for ExectVersion.Install() #134

merged 1 commit into from
May 11, 2023

Conversation

radeksimko
Copy link
Member

This enables us to accurately measure the impact of #132 (with vs without patch).

We could add the benchmark there, but with the PR made from a main branch it makes it difficult for me to contribute back to that PR directly, so I'm raising a separate PR.

go test ./releases -bench=BenchmarkExactVersion -benchmem -run=^#
goos: darwin
goarch: arm64
pkg: github.com/hashicorp/hc-install/releases
BenchmarkExactVersion-10    	      31	  37298613 ns/op	 8111621 B/op	    6950 allocs/op
PASS
ok  	github.com/hashicorp/hc-install/releases	2.250s

@radeksimko radeksimko requested a review from kmoe May 10, 2023 16:41
@radeksimko radeksimko marked this pull request as ready for review May 10, 2023 16:41
@radeksimko radeksimko mentioned this pull request May 10, 2023
Merged
@radeksimko radeksimko merged commit cb65e67 into main May 11, 2023
@radeksimko radeksimko deleted the t-install-benchmark branch May 11, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmoe kmoe kmoe approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @kmoe