Ensure go-version is 1.20.8
#156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in #115 I made the mistake of removing the last digit (patch version) from
.go-version.This remained mostly invisible issue which was only found because of security scanners which raised alerts due to older Go version but only on some builds (e.g.
linux/amd64but notlinux/arm64). This is because when a version without PATCH part is passed toactions/setup-go, it chooses any cached Go version which satisfies the constraint (1.20 in this case).The cache for the Go toolchain is OS/arch specific which is how we have ended up compiling
hc-installCLI with different Go versions at part of the same build (1.20.7 and 1.20.8 in this case).