Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httpclient: Reuse existing configured logger #240

Merged
merged 1 commit into from
Sep 4, 2024
Merged

httpclient: Reuse existing configured logger #240

merged 1 commit into from
Sep 4, 2024

Conversation

radeksimko
Copy link
Member

Fixes #239

@radeksimko radeksimko added the bug Something isn't working label Aug 23, 2024
@radeksimko radeksimko requested a review from a team as a code owner August 23, 2024 10:28
@kmoe
Copy link
Member

kmoe commented Aug 23, 2024

Can we add a regression test for the #239 behaviour?

kmoe
kmoe approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@kmoe kmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge with tests added or those can come in a later PR so as not to block release.

@xiehan
Copy link
Member

xiehan commented Aug 23, 2024

If we could hold off on doing a release until hashicorp/hc-passport-groups#1674 (hopefully) gets merged and I set up the same for hc-install, that would be great! That way we can kill two birds with one stone: both getting this release out, and verifying that managing the CRT approvers through Passport allows somebody other than Radek and Katy to do a release, as right now that group only includes the two of you.

@radeksimko
Copy link
Member Author

I'm not sure how to test this with the current setup in the context of a library.

We could be testing any STDOUT/STDERR output but that falls mostly under #65 so I'll merge this PR without a test and we can follow up there. - that is once https://github.com/hashicorp/hc-passport-groups/pull/1674 is merged.

@radeksimko radeksimko merged commit 8d6f663 into main Sep 4, 2024
11 checks passed
@radeksimko radeksimko deleted the b-reuse-logger branch September 4, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmoe kmoe kmoe approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP logs are leaking to stderr from v0.8.0 onwards
4 participants
@radeksimko @kmoe @xiehan @mutahhir