Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PreviousAddress field to ResourceChange to support moved block #95

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Add PreviousAddress field to ResourceChange to support moved block #95

merged 2 commits into from
Sep 12, 2023

Conversation

takaishi
Copy link
Contributor

This PR adds PreviousAddress field to support moved block.

#45

@takaishi takaishi marked this pull request as ready for review July 18, 2023 08:03
@takaishi takaishi requested review from a team as code owners July 18, 2023 08:03
@takaishi takaishi mentioned this pull request Aug 5, 2023
Closed
@liamcervante
Copy link
Member

Hi @takaishi, apologies for the delay here. The change looks good to me, but I'd like to see at least one test added for this. Could you add some configuration into the testdata directory that includes a moved block and the sample output from:

  • terraform show -json
  • terraform show -json planfile
  • terraform providers schema -json

Thanks!

@liamcervante liamcervante merged commit 9901d28 into hashicorp:main Sep 12, 2023
8 checks passed
@takaishi takaishi mentioned this pull request Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamcervante liamcervante liamcervante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takaishi @liamcervante