-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New SDKv2/logging documentation section #1011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to approve so I don't block this work, but I had a few questions and suggestions for you here. Overall, really great work - I think this will be very helpful for users!
Please push back on me where I've materially changed the meaning or misunderstood what's happening. Thank you for the chance to comment on this! :-)
Co-authored-by: Laura Pacilio <83350965+laurapacilio@users.noreply.github.com>
Co-authored-by: Laura Pacilio <83350965+laurapacilio@users.noreply.github.com>
20f6b8d
to
afe1761
Compare
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This includes a dedicated page to the new
NewLoggingHTTPTransport()
andNewSubsystemLoggingHTTPTransport()
helpers, introduced in #1006.Closes #1007