Add cloudformation delete protection

[dblooman]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #3496

Release note for CHANGELOG:

Add cloudformation termination protection

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[nywilken]

Thanks for submitting this, it looks like a great start! There are some contribution guidelines we need this to follow before we can continue reviewing it. Acceptance test coverage and Documentation updates. We can leave this open while you work on it in case there are questions. If you get stuck, you can check the CONTRIBUTING Guide for information on testing or you can post a comment on the PR . We’ll be looking for your update!

[0x91]

you'll likely need to update resourceAwsCloudFormationStackRead as well to lookup the current Termination Protection value of the stack when refreshing the state.

[bflad]

Hi @dblooman 👋 Since we haven't seen any reply or activity relating to the requested changes above, we are going to close this pull request for now. If you or someone else has the interest in continuing on this implementation, please submit a new pull request and we will take another look. Thanks.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!