Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append the info about IAM Server Certificate import #1090

Merged
merged 2 commits into from
Jul 10, 2017

Conversation

cazorla19
Copy link
Contributor

@cazorla19 cazorla19 commented Jul 10, 2017

I noticed that we missed an information about IAM certificates import. From the user side it looks like a Terraform cannot do this. So, I tried import by id and by name both. Only the last one succeeded.
So, please, update the docs.

@Ninir Ninir added the documentation Introduces or discusses updates to documentation. label Jul 10, 2017
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cazorla19

This seems very good to me!
Just left a small comment to address, will merge once discussed :)

Thanks!

IAM Server Certificates can be imported using the `name`, e.g.

```
$ terraform import aws_iam_server_certificate.sertificate example.com-certificate-until-2018
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the sertificate wanted there, with a s?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ninir I am going to make the change on this branch and then merge this - I believe it was a typo :)

Copy link
Contributor Author

@cazorla19 cazorla19 Jul 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely not. Thanks for fixing my typo!

@stack72 stack72 merged commit 29b7bf6 into hashicorp:master Jul 10, 2017
@stack72
Copy link
Contributor

stack72 commented Jul 10, 2017

Hi @cazorla19

Thanks for this work :)

Paul

@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants