Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/ecs_task_definition: clarify multiple volume blocks may be specified #1158

Merged

Conversation

azban
Copy link

@azban azban commented Jul 14, 2017

updated the aws_ecs_task_definition.volume to indicate that multiple volume blocks can be specified. matched the language used in aws_security_group.ingress.

reasoning: it is unclear/not explicit that multiple volume blocks may currently be specified. was noted by multiple people here: hashicorp/terraform#10836

relevant version: next version

Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @azban

This looks good to me!
Added a commit to provide anchors in the page (better UX) and rephrased a bit.

Thanks for the work here! 👍

@Ninir Ninir merged commit 8009b8f into hashicorp:master Jul 18, 2017
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants