Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetSubnets not allowed on LB type network #1941

Closed
wants to merge 1 commit into from
Closed

SetSubnets not allowed on LB type network #1941

wants to merge 1 commit into from

Conversation

dblooman
Copy link
Contributor

Covers #1925

@radeksimko radeksimko added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 18, 2017
@dblooman dblooman mentioned this pull request Oct 18, 2017
Closed
Ginja
Ginja reviewed Oct 18, 2017
View reviewed changes
aws/resource_aws_lb.go Outdated
@@ -390,6 +390,10 @@ func resourceAwsLbUpdate(d *schema.ResourceData, meta interface{}) error {
}

if d.HasChange("subnets") {
if d.Get("load_balancer_type").(string) == "network" {
return fmt.Errorf("Unable to upddate subnets for loadbalancer %s, updating subnets is not supported for type network", d.Id())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on supporting NLBs in TF 👍

Small typo upddate -> update

catsby
catsby suggested changes Nov 13, 2017
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should log make mention that the way to actually do the change they're seeking is to use terraform taint on this resource.

We also need to document this caveat in website/docs/r/lb.html.markdown.

@catsby
Copy link
Contributor

catsby commented Nov 13, 2017

Hey @DaveBlooman thanks for fixing this! There are just 2 things we need to merge though, we need to:

  • document this in the lb documentation
  • mention that terraform taint is the way to do change the subnets in our error message

We should mention taint in both places. If you can't get to these items I totally understand and will try to get to them this week. Thanks!

This was referenced Nov 13, 2017
Closed
Closed
@radeksimko radeksimko added the waiting-response Maintainers are waiting on response from community or contributor. label Nov 14, 2017
@catsby catsby mentioned this pull request Nov 14, 2017
Closed
3 tasks
@catsby
Copy link
Contributor

catsby commented Nov 14, 2017

Closing in favor of #2293 where I check off the items above

@catsby catsby closed this Nov 14, 2017
@catsby catsby mentioned this pull request Nov 15, 2017
Merged
2 tasks
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ginja Ginja Ginja left review comments

@catsby catsby catsby requested changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dblooman @catsby @Ginja @breathingdust @radeksimko