Dont recreate listener rule after priority change #23768

m-eitan · 2022-03-20T16:09:09Z

Dont recreate listener rule after priority change

It is possible to update the priority without recreating the rule, which is preferred of course. See docs.

Release Notes:

resource/aws_alb_listener_rule: Don't force recreate listener rule on priority change.

Acceptance Tests:

$ make testacc TESTS=.+updateRulePriority PKG=elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='.+updateRulePriority'  -timeout 180m
=== RUN   TestAccELBV2ListenerRule_updateRulePriority
=== PAUSE TestAccELBV2ListenerRule_updateRulePriority
=== CONT  TestAccELBV2ListenerRule_updateRulePriority
--- PASS: TestAccELBV2ListenerRule_updateRulePriority (259.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      259.164s

github-actions

Welcome @m-eitan 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

bschaatsbergen · 2022-03-21T09:43:28Z

Can you please run the acceptance tests and add them to the body of the PR description.

m-eitan · 2022-03-21T12:23:16Z

Can you please run the acceptance tests and add them to the body of the PR description.

Updated 👍

m-eitan · 2022-04-07T11:08:01Z

Any update regarding this PR? @bschaatsbergen @justinretzolk

justinretzolk · 2022-04-08T19:46:49Z

Hey @m-eitan 👋 Thank you for checking in on this, and for your contribution! Unfortunately, I'm not able to provide an estimate on when this will be merged due to the potential of shifting priorities (we prioritize work by count of ":+1:" reactions, as well as a few other things). A larger prioritization document is in the works, but in the meantime additional information may be found in the FAQ.

m-eitan · 2022-04-10T13:22:25Z

@justinretzolk Understood, thank you

m-eitan · 2022-05-03T07:16:09Z

@justinretzolk I would really appreciate if you can take a look again, there are already 6 upvotes and it's a really small change but very important for us to be able to re-order listener rules without downtime using the provider

bschaatsbergen · 2022-05-03T07:58:58Z

Hi @m-eitan, I can take a look at this PR in the coming 2 days. I'll need some time to dive into it locally and see why it currently is being forced to recreate. Meanwhile, thanks for your contribution 👍

bschaatsbergen · 2022-05-05T19:55:16Z

Seems perfectly possible 👍

Terraform will perform the following actions:

  # aws_lb_listener_rule.non_static will be updated in-place
  ~ resource "aws_lb_listener_rule" "non_static" {
        id           = "arn:aws:elasticloadbalancing:eu-central-1:822224938642:listener-rule/app/test-lb-tf/420e0d31f1b15ac1/7feed816395e01ae/63bdb0bc028425c1"
      ~ priority     = 104 -> 101
        tags         = {}
        # (3 unchanged attributes hidden)


        # (3 unchanged blocks hidden)
    }

  # aws_lb_listener_rule.static will be updated in-place
  ~ resource "aws_lb_listener_rule" "static" {
        id           = "arn:aws:elasticloadbalancing:eu-central-1:822224938642:listener-rule/app/test-lb-tf/420e0d31f1b15ac1/7feed816395e01ae/4b79897a3bafe9f0"
      ~ priority     = 110 -> 100
        tags         = {}
        # (3 unchanged attributes hidden)


        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.
aws_lb_listener_rule.non_static: Modifying... [id=arn:aws:elasticloadbalancing:eu-central-1:822224938642:listener-rule/app/test-lb-tf/420e0d31f1b15ac1/7feed816395e01ae/63bdb0bc028425c1]
aws_lb_listener_rule.static: Modifying... [id=arn:aws:elasticloadbalancing:eu-central-1:822224938642:listener-rule/app/test-lb-tf/420e0d31f1b15ac1/7feed816395e01ae/4b79897a3bafe9f0]
aws_lb_listener_rule.non_static: Modifications complete after 1s [id=arn:aws:elasticloadbalancing:eu-central-1:822224938642:listener-rule/app/test-lb-tf/420e0d31f1b15ac1/7feed816395e01ae/63bdb0bc028425c1]
aws_lb_listener_rule.static: Modifications complete after 1s [id=arn:aws:elasticloadbalancing:eu-central-1:822224938642:listener-rule/app/test-lb-tf/420e0d31f1b15ac1/7feed816395e01ae/4b79897a3bafe9f0]

Apply complete! Resources: 0 added, 2 changed, 0 destroyed.

bschaatsbergen · 2022-05-05T20:32:12Z

1 comment before we can get this approved and merged:

Please create an entry in the .changelog directory using 23768.txt as the filename.

Once ☝️ is done I'll ask one of the internal folks to sign of the PR.

Test (TestAccELBV2ListenerRule_updateRulePriority) seems to pass too 👍

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2ListenerRule_updateRulePriority'  -timeout 180m
=== RUN   TestAccELBV2ListenerRule_updateRulePriority
=== PAUSE TestAccELBV2ListenerRule_updateRulePriority
=== CONT  TestAccELBV2ListenerRule_updateRulePriority
--- PASS: TestAccELBV2ListenerRule_updateRulePriority (278.91s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      278.944s

m-eitan · 2022-05-09T11:26:39Z

@bschaatsbergen Thanks a lot for your response :)
Added the changelog

bschaatsbergen

LGTM 🚀

@ewbankkit, could you check this out please :)

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccELBV2ListenerRule_updateRulePriority\|TestAccELBV2ListenerRule_basic\|TestAccELBV2ListenerRule_changeListenerRuleARNForcesNew' PKG=elbv2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 2  -run=TestAccELBV2ListenerRule_updateRulePriority\|TestAccELBV2ListenerRule_basic\|TestAccELBV2ListenerRule_changeListenerRuleARNForcesNew -timeout 180m
=== RUN   TestAccELBV2ListenerRule_basic
=== PAUSE TestAccELBV2ListenerRule_basic
=== RUN   TestAccELBV2ListenerRule_updateRulePriority
=== PAUSE TestAccELBV2ListenerRule_updateRulePriority
=== RUN   TestAccELBV2ListenerRule_changeListenerRuleARNForcesNew
=== PAUSE TestAccELBV2ListenerRule_changeListenerRuleARNForcesNew
=== CONT  TestAccELBV2ListenerRule_basic
=== CONT  TestAccELBV2ListenerRule_changeListenerRuleARNForcesNew
--- PASS: TestAccELBV2ListenerRule_basic (240.54s)
=== CONT  TestAccELBV2ListenerRule_updateRulePriority
--- PASS: TestAccELBV2ListenerRule_changeListenerRuleARNForcesNew (252.01s)
--- PASS: TestAccELBV2ListenerRule_updateRulePriority (266.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	510.582s

ewbankkit · 2022-05-09T17:46:28Z

@m-eitan Thanks for the contribution 🎉 👏.

bschaatsbergen · 2022-05-09T18:04:29Z

Nice, thanks for the contribution 🎉 @m-eitan

m-eitan · 2022-05-10T07:35:06Z

Awesome thanks a lot for all your work :) @bschaatsbergen @ewbankkit

github-actions · 2022-05-13T17:26:12Z

This functionality has been released in v4.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-06-13T02:37:14Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Dont recreate listener rule after priority change

4eb2abe

github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Mar 20, 2022

github-actions bot reviewed Mar 20, 2022

View reviewed changes

justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 21, 2022

Update changelog.txt for hashicorp#23768

1388db9

bschaatsbergen approved these changes May 9, 2022

View reviewed changes

Add and use 'testAccCheckListenerRuleNotRecreated'.

d42b44f

github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels May 9, 2022

ewbankkit approved these changes May 9, 2022

View reviewed changes

ewbankkit merged commit 8712d9a into hashicorp:main May 9, 2022

github-actions bot added this to the v4.14.0 milestone May 9, 2022

github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dont recreate listener rule after priority change #23768

Dont recreate listener rule after priority change #23768

m-eitan commented Mar 20, 2022 •

edited

Loading

github-actions bot left a comment

bschaatsbergen commented Mar 21, 2022

m-eitan commented Mar 21, 2022

m-eitan commented Apr 7, 2022 •

edited

Loading

justinretzolk commented Apr 8, 2022

m-eitan commented Apr 10, 2022

m-eitan commented May 3, 2022

bschaatsbergen commented May 3, 2022

bschaatsbergen commented May 5, 2022

bschaatsbergen commented May 5, 2022 •

edited

Loading

m-eitan commented May 9, 2022

bschaatsbergen left a comment •

edited

Loading

ewbankkit left a comment

ewbankkit commented May 9, 2022

bschaatsbergen commented May 9, 2022 •

edited

Loading

m-eitan commented May 10, 2022

github-actions bot commented May 13, 2022

github-actions bot commented Jun 13, 2022

Dont recreate listener rule after priority change #23768

Dont recreate listener rule after priority change #23768

Conversation

m-eitan commented Mar 20, 2022 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

bschaatsbergen commented Mar 21, 2022

m-eitan commented Mar 21, 2022

m-eitan commented Apr 7, 2022 • edited Loading

justinretzolk commented Apr 8, 2022

m-eitan commented Apr 10, 2022

m-eitan commented May 3, 2022

bschaatsbergen commented May 3, 2022

bschaatsbergen commented May 5, 2022

bschaatsbergen commented May 5, 2022 • edited Loading

m-eitan commented May 9, 2022

bschaatsbergen left a comment • edited Loading

Choose a reason for hiding this comment

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented May 9, 2022

bschaatsbergen commented May 9, 2022 • edited Loading

m-eitan commented May 10, 2022

github-actions bot commented May 13, 2022

github-actions bot commented Jun 13, 2022

m-eitan commented Mar 20, 2022 •

edited

Loading

m-eitan commented Apr 7, 2022 •

edited

Loading

bschaatsbergen commented May 5, 2022 •

edited

Loading

bschaatsbergen left a comment •

edited

Loading

bschaatsbergen commented May 9, 2022 •

edited

Loading