Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: Amazon Rekognition Stream Processor & Collection #31889

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tkasuz
Copy link
Contributor

@tkasuz tkasuz commented Jun 12, 2023

Description

Adds new resources for Amazon Rekognition Stream Processor and Collection.

Relations

Relates #9359

References

Output from Acceptance Testing

  • Collection
$ make testacc TESTS=TestAccRekognitionCollection_ PKG=rekognition
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rekognition/... -v -count 1 -parallel 20 -run='TestAccRekognitionCollection_'  -timeout 180m
=== RUN   TestAccRekognitionCollection_basic
=== PAUSE TestAccRekognitionCollection_basic
=== RUN   TestAccRekognitionCollection_extend_tags
=== PAUSE TestAccRekognitionCollection_extend_tags
=== RUN   TestAccRekognitionCollection_disappears
=== PAUSE TestAccRekognitionCollection_disappears
=== CONT  TestAccRekognitionCollection_basic
=== CONT  TestAccRekognitionCollection_disappears
=== CONT  TestAccRekognitionCollection_extend_tags
--- PASS: TestAccRekognitionCollection_disappears (26.80s)
--- PASS: TestAccRekognitionCollection_basic (36.11s)
--- PASS: TestAccRekognitionCollection_extend_tags (69.96s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rekognition        75.652s
  • Stream Processor for Label Detection
$ make testacc TESTS=TestAccRekognitionStreamProcessor_connectedHome_ PKG=rekognition
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rekognition/... -v -count 1 -parallel 20 -run='TestAccRekognitionStreamProcessor_connectedHome_'  -timeout 180m
=== RUN   TestAccRekognitionStreamProcessor_connectedHome_base
=== PAUSE TestAccRekognitionStreamProcessor_connectedHome_base
=== RUN   TestAccRekognitionStreamProcessor_connectedHome_disappears
=== PAUSE TestAccRekognitionStreamProcessor_connectedHome_disappears
=== RUN   TestAccRekognitionStreamProcessor_connectedHome_extend_tags
=== PAUSE TestAccRekognitionStreamProcessor_connectedHome_extend_tags
=== RUN   TestAccRekognitionStreamProcessor_connectedHome_extend_minConfidence
=== PAUSE TestAccRekognitionStreamProcessor_connectedHome_extend_minConfidence
=== RUN   TestAccRekognitionStreamProcessor_connectedHome_extend_dataSharedPreference
=== PAUSE TestAccRekognitionStreamProcessor_connectedHome_extend_dataSharedPreference
=== RUN   TestAccRekognitionStreamProcessor_connectedHome_extend_kmsKeyId
=== PAUSE TestAccRekognitionStreamProcessor_connectedHome_extend_kmsKeyId
=== RUN   TestAccRekognitionStreamProcessor_connectedHome_extend_regionsOfInterest_boundingBox_create
=== PAUSE TestAccRekognitionStreamProcessor_connectedHome_extend_regionsOfInterest_boundingBox_create
=== RUN   TestAccRekognitionStreamProcessor_connectedHome_extend_regionsOfInterest_boundingBox_update
=== PAUSE TestAccRekognitionStreamProcessor_connectedHome_extend_regionsOfInterest_boundingBox_update
=== RUN   TestAccRekognitionStreamProcessor_connectedHome_extend_regionsOfInterest_polygon_create
=== PAUSE TestAccRekognitionStreamProcessor_connectedHome_extend_regionsOfInterest_polygon_create
=== RUN   TestAccRekognitionStreamProcessor_connectedHome_extend_regionsOfInterest_polygon_update
=== PAUSE TestAccRekognitionStreamProcessor_connectedHome_extend_regionsOfInterest_polygon_update
=== CONT  TestAccRekognitionStreamProcessor_connectedHome_base
=== CONT  TestAccRekognitionStreamProcessor_connectedHome_extend_kmsKeyId
=== CONT  TestAccRekognitionStreamProcessor_connectedHome_extend_regionsOfInterest_polygon_create
=== CONT  TestAccRekognitionStreamProcessor_connectedHome_extend_regionsOfInterest_boundingBox_update
=== CONT  TestAccRekognitionStreamProcessor_connectedHome_extend_regionsOfInterest_polygon_update
=== CONT  TestAccRekognitionStreamProcessor_connectedHome_extend_minConfidence
=== CONT  TestAccRekognitionStreamProcessor_connectedHome_extend_tags
=== CONT  TestAccRekognitionStreamProcessor_connectedHome_extend_regionsOfInterest_boundingBox_create
=== CONT  TestAccRekognitionStreamProcessor_connectedHome_disappears
=== CONT  TestAccRekognitionStreamProcessor_connectedHome_extend_dataSharedPreference
--- PASS: TestAccRekognitionStreamProcessor_connectedHome_disappears (152.76s)
--- PASS: TestAccRekognitionStreamProcessor_connectedHome_extend_regionsOfInterest_polygon_create (164.35s)
--- PASS: TestAccRekognitionStreamProcessor_connectedHome_base (164.62s)
--- PASS: TestAccRekognitionStreamProcessor_connectedHome_extend_regionsOfInterest_boundingBox_create (167.16s)
--- PASS: TestAccRekognitionStreamProcessor_connectedHome_extend_kmsKeyId (167.32s)
--- PASS: TestAccRekognitionStreamProcessor_connectedHome_extend_dataSharedPreference (205.19s)
--- PASS: TestAccRekognitionStreamProcessor_connectedHome_extend_regionsOfInterest_polygon_update (206.15s)
--- PASS: TestAccRekognitionStreamProcessor_connectedHome_extend_regionsOfInterest_boundingBox_update (207.38s)
--- PASS: TestAccRekognitionStreamProcessor_connectedHome_extend_minConfidence (208.15s)
--- PASS: TestAccRekognitionStreamProcessor_connectedHome_extend_tags (225.35s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rekognition        230.741s
  • Stream Processor for Face Search
$ make testacc  TESTS=TestAccRekognitionStreamProcessor_faceSearch_ PKG=rekognition
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rekognition/... -v -count 1 -parallel 20 -run='TestAccRekognitionStreamProcessor_faceSearch_'  -timeout 180m
=== RUN   TestAccRekognitionStreamProcessor_faceSearch_base
=== PAUSE TestAccRekognitionStreamProcessor_faceSearch_base
=== RUN   TestAccRekognitionStreamProcessor_faceSearch_disappears
=== PAUSE TestAccRekognitionStreamProcessor_faceSearch_disappears
=== RUN   TestAccRekognitionStreamProcessor_faceSearch_extend_faceMatchThreshold
=== PAUSE TestAccRekognitionStreamProcessor_faceSearch_extend_faceMatchThreshold
=== CONT  TestAccRekognitionStreamProcessor_faceSearch_base
=== CONT  TestAccRekognitionStreamProcessor_faceSearch_disappears
=== CONT  TestAccRekognitionStreamProcessor_faceSearch_extend_faceMatchThreshold
--- PASS: TestAccRekognitionStreamProcessor_faceSearch_disappears (119.99s)
--- PASS: TestAccRekognitionStreamProcessor_faceSearch_base (125.02s)
--- PASS: TestAccRekognitionStreamProcessor_faceSearch_extend_faceMatchThreshold (125.02s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rekognition        130.318s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/rekognition Issues and PRs that pertain to the rekognition service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Jun 12, 2023
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@tkasuz tkasuz force-pushed the f-rekognition-streamprocessor branch from a319d4b to d0fae90 Compare June 12, 2023 04:19
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @tkasuz 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/rekognition Issues and PRs that pertain to the rekognition service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants