Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Source route53_resolver_rules filter by DomainName #35398

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AliAllomani
Copy link
Contributor

@AliAllomani AliAllomani commented Jan 19, 2024

Description

Adding new argument domain_regex to data.aws_route53_resolver_rules to support retrieving Route53 resolver rules by domain name

Relations

Closes #35397

References

Output from Acceptance Testing

% make testacc TESTS=TestAccRoute53ResolverRulesDataSource_domainRegex PKG=route53resolver
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 20 -run='TestAccRoute53ResolverRulesDataSource_domainRegex'  -timeout 360m
=== RUN   TestAccRoute53ResolverRulesDataSource_domainRegex
=== PAUSE TestAccRoute53ResolverRulesDataSource_domainRegex
=== CONT  TestAccRoute53ResolverRulesDataSource_domainRegex
--- PASS: TestAccRoute53ResolverRulesDataSource_domainRegex (18.79s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    67.960s



% make testacc TESTS=TestAccRoute53ResolverRulesDataSource_nonExistentDomainRegex PKG=route53resolver
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 20 -run='TestAccRoute53ResolverRulesDataSource_nonExistentDomainRegex'  -timeout 360m
=== RUN   TestAccRoute53ResolverRulesDataSource_nonExistentDomainRegex
=== PAUSE TestAccRoute53ResolverRulesDataSource_nonExistentDomainRegex
=== CONT  TestAccRoute53ResolverRulesDataSource_nonExistentDomainRegex
--- PASS: TestAccRoute53ResolverRulesDataSource_nonExistentDomainRegex (13.40s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    59.117s
...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53resolver Issues and PRs that pertain to the route53resolver service. labels Jan 19, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 19, 2024
@AliAllomani AliAllomani marked this pull request as ready for review January 19, 2024 15:18
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Data Source route53_resolver_rules filter by DomainName
2 participants