Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-aws db instance- support for UpgradeStorageConfig #36904

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Apr 14, 2024

Description

Relations

Closes #36617

References

Output from Acceptance Testing

% make testacc TESTS=TestAccRDSInstance_ReplicateSourceDB_upgrade PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstance_ReplicateSourceDB_upgrade'  -timeout 360m
=== RUN   TestAccRDSInstance_ReplicateSourceDB_upgrade
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_upgrade
=== CONT  TestAccRDSInstance_ReplicateSourceDB_upgrade
--- PASS: TestAccRDSInstance_ReplicateSourceDB_upgrade (1377.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1389.088s
% make testacc TESTS=TestAccRDSInstance_ReplicateSourceDB_basic PKG=rds  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstance_ReplicateSourceDB_basic'  -timeout 360m
=== RUN   TestAccRDSInstance_ReplicateSourceDB_basic
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_basic
=== CONT  TestAccRDSInstance_ReplicateSourceDB_basic
--- PASS: TestAccRDSInstance_ReplicateSourceDB_basic (1640.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1660.159s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/M Managed by automation to categorize the size of a PR. label Apr 14, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 14, 2024
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. labels Apr 14, 2024
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Apr 14, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add UpgradeStorageConfig to CreateDBInstanceReadReplica
2 participants