Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_route53profiles_profile #37124

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint fixes; add website documentation
  • Loading branch information
rubenandre committed Apr 26, 2024
commit 75abe11002bb18b0dfbc37012ac9156c3ad4ac77
7 changes: 5 additions & 2 deletions internal/service/route53profiles/exports_test.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
// Copyright (c) HashiCorp, Inc.
// SPDX-License-Identifier: MPL-2.0

package route53profiles

var (
Route53ProfilesProfile = newResourceProfile
FindProfileByID = findProfileByID
Route53Profile = newResourceProfile
FindProfileByID = findProfileByID
)
3 changes: 3 additions & 0 deletions internal/service/route53profiles/profile.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) HashiCorp, Inc.

Check failure on line 1 in internal/service/route53profiles/profile.go

View workflow job for this annotation

GitHub Actions / importlint

Imports of different types are not allowed in the same group (0): "context" != "github.com/hashicorp/terraform-plugin-sdk/v2/helper/id"
// SPDX-License-Identifier: MPL-2.0

package route53profiles
Expand Down Expand Up @@ -37,6 +37,7 @@
r := &resourceProfile{}

r.SetDefaultCreateTimeout(30 * time.Minute)
r.SetDefaultReadTimeout(30 * time.Minute)
r.SetDefaultUpdateTimeout(30 * time.Minute)
r.SetDefaultDeleteTimeout(30 * time.Minute)

Expand Down Expand Up @@ -112,6 +113,8 @@

// Even tough the tags are Map based, CreateProfile expects a slice of tags
for k, v := range getTagsIn(ctx) {
k := k
v := v
tags = append(tags, awstypes.Tag{Key: &k, Value: &v})
}

Expand Down
2 changes: 1 addition & 1 deletion internal/service/route53profiles/profile_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) HashiCorp, Inc.

Check failure on line 1 in internal/service/route53profiles/profile_test.go

View workflow job for this annotation

GitHub Actions / importlint

Imports of different types are not allowed in the same group (0): "context" != awstypes "github.com/aws/aws-sdk-go-v2/service/route53profiles/types"
// SPDX-License-Identifier: MPL-2.0

package route53profiles_test
Expand Down Expand Up @@ -70,7 +70,7 @@
Config: testAccProfileConfig_basic(rName),
Check: resource.ComposeTestCheckFunc(
testAccCheckProfileExists(ctx, resourceName, &v),
acctest.CheckFrameworkResourceDisappears(ctx, acctest.Provider, tfroute53profiles.Route53ProfilesProfile, resourceName),
acctest.CheckFrameworkResourceDisappears(ctx, acctest.Provider, tfroute53profiles.Route53Profile, resourceName),
),
ExpectNonEmptyPlan: true,
},
Expand Down
41 changes: 19 additions & 22 deletions website/docs/r/route53profiles_profile.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -5,51 +5,48 @@ page_title: "AWS: aws_route53profiles_profile"
description: |-
Terraform resource for managing an AWS Route 53 Profiles Profile.
---
<!---
TIP: A few guiding principles for writing documentation:
1. Use simple language while avoiding jargon and figures of speech.
2. Focus on brevity and clarity to keep a reader's attention.
3. Use active voice and present tense whenever you can.
4. Document your feature as it exists now; do not mention the future or past if you can help it.
5. Use accessible and inclusive language.
--->`

# Resource: aws_route53profiles_profile

Terraform resource for managing an AWS Route 53 Profiles Profile.

## Example Usage

### Basic Usage
### Empty Profile

```terraform
resource "aws_route53profiles_profile" "example" {
name = "example"
}
```

## Argument Reference

The following arguments are required:

* `example_arg` - (Required) Concise argument description. Do not begin the description with "An", "The", "Defines", "Indicates", or "Specifies," as these are verbose. In other words, "Indicates the amount of storage," can be rewritten as "Amount of storage," without losing any information.

The following arguments are optional:

* `optional_arg` - (Optional) Concise argument description. Do not begin the description with "An", "The", "Defines", "Indicates", or "Specifies," as these are verbose. In other words, "Indicates the amount of storage," can be rewritten as "Amount of storage," without losing any information.
* `name` - (Required) The name of the Profile.

## Attribute Reference

This resource exports the following attributes in addition to the arguments above:

* `arn` - ARN of the Profile. Do not begin the description with "An", "The", "Defines", "Indicates", or "Specifies," as these are verbose. In other words, "Indicates the amount of storage," can be rewritten as "Amount of storage," without losing any information.
* `example_attribute` - Concise description. Do not begin the description with "An", "The", "Defines", "Indicates", or "Specifies," as these are verbose. In other words, "Indicates the amount of storage," can be rewritten as "Amount of storage," without losing any information.
* `arn` - The ARN of the Profile.
* `id` - The ID of the Profile.
* `name` - The name of the Profile.
* `status` - The status of the Profile. Valid values [AWS docs](https://docs.aws.amazon.com/Route53/latest/APIReference/API_route53profiles_Profile.html)
* `status_message` - The status message of the Profile.
* `share_status` - The share status of the Profile. Valid values [AWS docs](https://docs.aws.amazon.com/Route53/latest/APIReference/API_route53profiles_Profile.html)
* `tags_all` - Map of tags assigned to the resource, including those inherited from the provider [`default_tags` configuration block](https://registry.terraform.io/providers/hashicorp/aws/latest/docs#default_tags-configuration-block).


## Timeouts

[Configuration options](https://developer.hashicorp.com/terraform/language/resources/syntax#operation-timeouts):

* `create` - (Default `60m`)
* `update` - (Default `180m`)
* `delete` - (Default `90m`)
* `create` - (Default `30m`)
* `read` - (Default `30m`)
* `update` - (Default `30m`)
* `delete` - (Default `30m`)

## Import

Expand All @@ -58,12 +55,12 @@ In Terraform v1.5.0 and later, use an [`import` block](https://developer.hashico
```terraform
import {
to = aws_route53profiles_profile.example
id = "profile-id-12345678"
id = "rp-12345678"
}
```

Using `terraform import`, import Route 53 Profiles Profile using the `example_id_arg`. For example:
Using `terraform import`, import Route 53 Profiles Profile using the `example`. For example:

```console
% terraform import aws_route53profiles_profile.example profile-id-12345678
% terraform import aws_route53profiles_profile.example rp-12345678
```

This file was deleted.

Loading