Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate IoT services to AWS Go SDKv2 #37152

Merged
merged 57 commits into from
Jul 2, 2024
Merged

Migrate IoT services to AWS Go SDKv2 #37152

merged 57 commits into from
Jul 2, 2024

Conversation

DanielRieske
Copy link
Contributor

@DanielRieske DanielRieske commented Apr 29, 2024 •
edited
Loading

Description

Migrated the following services to SDKv2 and addressed some technical depth within them.

  • IoT Analytics Service
  • IoT Core Service
  • IoT Events Service
  • IoT Greengrass Service

Relations

Relates #32976

Closes #36170
Closes #36171
Closes #36172
Closes #36173
Closes #36834
Closes #37323

References

Output from Acceptance Testing

--- PASS: TestAccIoTThingGroup_disappears (17.01s)
--- PASS: TestAccIoTAuthorizer_basic (39.05s)
--- PASS: TestAccIoTTopicRule_elasticSearch (44.65s)
--- PASS: TestAccIoTTopicRule_dynamoDBv2 (39.13s)
--- PASS: TestAccIoTTopicRule_dynamoDB (42.98s)
--- PASS: TestAccIoTTopicRule_cloudWatchMetric (42.59s)
--- PASS: TestAccIoTTopicRule_cloudWatchLogs (42.98s)
--- PASS: TestAccIoTTopicRule_disappears (16.20s)
--- PASS: TestAccIoTTopicRule_cloudWatchAlarm (43.64s)
--- PASS: TestAccIoTTopicRule_tags (43.95s)
--- PASS: TestAccIoTTopicRule_basic (19.44s)
--- PASS: TestAccIoTEventConfigurations_serial (16.11s)
    --- PASS: TestAccIoTEventConfigurations_serial/basic (16.11s)
--- PASS: TestAccIoTThingGroup_basic (17.46s)
--- PASS: TestAccIoTThingGroupMembership_overrideDynamicGroup (17.92s)
--- PASS: TestAccIoTThingGroupMembership_disappears_ThingGroup (15.72s)
--- PASS: TestAccIoTThingGroupMembership_disappears_Thing (15.81s)
--- PASS: TestAccIoTThingGroupMembership_disappears (15.78s)
--- PASS: TestAccIoTThingGroupMembership_basic (18.22s)
--- PASS: TestAccIoTRoleAlias_tags (45.15s)
--- PASS: TestAccIoTRoleAlias_basic (76.04s)
--- PASS: TestAccIoTRegistrationCodeDataSource_basic (11.10s)
--- PASS: TestAccIoTProvisioningTemplate_update (40.37s)
--- PASS: TestAccIoTProvisioningTemplate_tags (52.43s)
--- PASS: TestAccIoTProvisioningTemplate_disappears (24.25s)
--- PASS: TestAccIoTProvisioningTemplate_basic (26.97s)
--- PASS: TestAccIoTPolicy_prune (83.75s)
--- PASS: TestAccIoTPolicy_update (29.39s)
--- PASS: TestAccIoTTopicRuleDestination_disappears (545.25s)
--- PASS: TestAccIoTPolicy_tags (40.59s)
--- PASS: TestAccIoTPolicy_disappears (15.57s)
--- PASS: TestAccIoTPolicy_basic (18.49s)
--- PASS: TestAccIoTTopicRuleDestination_basic (738.69s)
--- PASS: TestAccIoTPolicyAttachment_basic (52.25s)
--- PASS: TestAccIoTLoggingOptions_serial (64.28s)
    --- PASS: TestAccIoTLoggingOptions_serial/basic (25.35s)
    --- PASS: TestAccIoTLoggingOptions_serial/update (38.93s)
--- PASS: TestAccIoTIndexingConfiguration_serial (36.01s)
    --- PASS: TestAccIoTIndexingConfiguration_serial/basic (17.76s)
    --- PASS: TestAccIoTIndexingConfiguration_serial/allAttributes (18.25s)
--- PASS: TestAccIoTThing_full (344.45s)
--- PASS: TestAccIoTThingType_full (331.40s)
--- PASS: TestAccIoTThingType_tags (343.23s)
--- PASS: TestAccIoTThingGroup_properties (29.64s)
--- PASS: TestAccIoTThing_basic (17.21s)
--- PASS: TestAccIoTThingPrincipalAttachment_basic (62.48s)
--- PASS: TestAccIoTCACertificate_tags (37.79s)
=== RUN   TestAccIoTDomainConfiguration_basic
    domain_configuration_test.go:24: Environment variable ACM_CERTIFICATE_ROOT_DOMAIN is not set. For DNS validation requests, this domain must be publicly accessible and configurable via Route53 during the testing. For email validation requests, you must have access to one of the five standard email addresses used (admin|administrator|hostmaster|postmaster|webmaster)@domain or one of the WHOIS contact addresses.
--- SKIP: TestAccIoTDomainConfiguration_basic (0.00s)
=== RUN   TestAccIoTDomainConfiguration_disappears
    domain_configuration_test.go:64: Environment variable ACM_CERTIFICATE_ROOT_DOMAIN is not set. For DNS validation requests, this domain must be publicly accessible and configurable via Route53 during the testing. For email validation requests, you must have access to one of the five standard email addresses used (admin|administrator|hostmaster|postmaster|webmaster)@domain or one of the WHOIS contact addresses.
--- SKIP: TestAccIoTDomainConfiguration_disappears (0.00s)
=== RUN   TestAccIoTDomainConfiguration_tags
    domain_configuration_test.go:90: Environment variable ACM_CERTIFICATE_ROOT_DOMAIN is not set. For DNS validation requests, this domain must be publicly accessible and configurable via Route53 during the testing. For email validation requests, you must have access to one of the five standard email addresses used (admin|administrator|hostmaster|postmaster|webmaster)@domain or one of the WHOIS contact addresses.
--- SKIP: TestAccIoTDomainConfiguration_tags (0.00s)
=== RUN   TestAccIoTDomainConfiguration_update
    domain_configuration_test.go:137: Environment variable ACM_CERTIFICATE_ROOT_DOMAIN is not set. For DNS validation requests, this domain must be publicly accessible and configurable via Route53 during the testing. For email validation requests, you must have access to one of the five standard email addresses used (admin|administrator|hostmaster|postmaster|webmaster)@domain or one of the WHOIS contact addresses.
--- SKIP: TestAccIoTDomainConfiguration_update (0.00s)
=== RUN   TestAccIoTDomainConfiguration_awsManaged
    domain_configuration_test.go:181: Environment variable IOT_DOMAIN_CONFIGURATION_TEST_AWS_MANAGED is not set, skipping test
--- SKIP: TestAccIoTDomainConfiguration_awsManaged (0.00s)
--- PASS: TestAccIoTEndpointDataSource_EndpointType_iotJobs (11.27s)
--- PASS: TestAccIoTEndpointDataSource_EndpointType_iotDataATS (11.23s)
--- PASS: TestAccIoTEndpointDataSource_EndpointType_iotData (11.21s)
--- PASS: TestAccIoTEndpointDataSource_EndpointType_iotCredentialProvider (11.09s)
--- PASS: TestAccIoTEndpointDataSource_basic (11.21s)
--- PASS: TestAccIoTCertificate_Keys_existingCertificate (25.40s)
--- PASS: TestAccIoTCertificate_Keys_certificate (14.86s)
--- PASS: TestAccIoTTopicRuleDestination_enabled (1226.55s)
--- PASS: TestAccIoTCertificate_csr (14.56s)
--- PASS: TestAccIoTCACertificate_registrationConfig (27.81s)
--- PASS: TestAccIoTCACertificate_defaultMode (30.23s)
--- PASS: TestAccIoTThingGroup_parentGroup (21.36s)
--- PASS: TestAccIoTThingType_disappears (317.37s)
--- PASS: TestAccIoTBillingGroup_disappears (16.04s)
--- PASS: TestAccIoTCACertificate_disappears (16.29s)
--- PASS: TestAccIoTThingType_basic (319.50s)
--- PASS: TestAccIoTCACertificate_basic (16.20s)
--- PASS: TestAccIoTThingGroup_tags (43.31s)
--- PASS: TestAccIoTTopicRule_lambda (20.21s)
--- PASS: TestAccIoTBillingGroup_properties (31.46s)
--- PASS: TestAccIoTBillingGroup_tags (42.77s)
--- PASS: TestAccIoTTopicRule_updateKinesisErrorAction (44.68s)
--- PASS: TestAccIoTTopicRule_errorAction (30.62s)
--- PASS: TestAccIoTTopicRule_Timestream (44.73s)
--- PASS: TestAccIoTTopicRule_Step_functions (44.43s)
--- PASS: TestAccIoTTopicRule_sqs (44.92s)
--- PASS: TestAccIoTTopicRule_sns (44.79s)
--- PASS: TestAccIoTTopicRule_republishWithQos (30.74s)
--- PASS: TestAccIoTTopicRule_s3 (45.18s)
--- PASS: TestAccIoTTopicRule_IoT_analytics_batch_mode (41.72s)
--- PASS: TestAccIoTTopicRule_republish (45.06s)
--- PASS: TestAccIoTTopicRule_kinesis (45.43s)
--- PASS: TestAccIoTTopicRule_IoT_events (26.99s)
--- PASS: TestAccIoTTopicRule_IoT_events_batch_mode (40.52s)
--- PASS: TestAccIoTTopicRule_kafka (70.84s)
--- PASS: TestAccIoTTopicRule_Firehose_batch_mode (44.29s)
--- PASS: TestAccIoTTopicRule_IoT_analytics (40.55s)
--- PASS: TestAccIoTAuthorizer_signingDisabled (37.98s)
--- PASS: TestAccIoTTopicRule_http (57.12s)
--- PASS: TestAccIoTTopicRule_Firehose_separator (44.50s)
--- PASS: TestAccIoTTopicRule_firehose (43.95s)
--- PASS: TestAccIoTAuthorizer_disappears (35.04s)
--- PASS: TestAccIoTBillingGroup_basic (18.56s)
--- PASS: TestAccIoTAuthorizer_update (48.01s)
--- PASS: TestAccIoTAuthorizer_tags (65.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	1755.809s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iot Issues and PRs that pertain to the iot service. service/greengrass Issues and PRs that pertain to the greengrass service. service/iotevents Issues and PRs that pertain to the iotevents service. service/iotanalytics Issues and PRs that pertain to the iotanalytics service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. github_actions Pull requests that update Github_actions code labels Apr 29, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Apr 29, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@justinretzolk justinretzolk added aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 30, 2024
@DanielRieske DanielRieske changed the title Migrate IoT Services to AWS Go SDKv2 Migrate IoT services to AWS Go SDKv2 May 9, 2024
@ewbankkit
r/aws_iot_ca_certificate: Reduce visibility.
075a4ef
@ewbankkit
r/aws_iot_certificate: Reduce visibility.
7a6d979
@ewbankkit
r/aws_iot_domain_configuration: Reduce visibility.
67e160e
@ewbankkit
d/aws_iot_endoint: Reduce visibility.
339c07a
@ewbankkit
r/aws_iot_event_configurations: Reduce visibility.
f698930
@ewbankkit
r/aws_iot_thing_type: Reduce visibility.
e339f39
@ewbankkit
r/aws_iot_indexing_configuration: Reduce visibility.
8fb56a1
@ewbankkit
r/aws_iot_policy_attachment: Reduce visibility.
2e6e95d
@ewbankkit
r/aws_iot_policy: Reduce visibility.
be0dafa
@ewbankkit
r/aws_iot_provisioning_template: Reduce visibility.
c0c28cf
@ewbankkit
d/aws_iot_registration_code: Reduce visibility.
6636aac
@ewbankkit
r/aws_iot_role_alias: Reduce visibility.
b99cc86
@ewbankkit
r/aws_iot_thing_group_membership: Reduce visibility.
707f2db
@ewbankkit
r/aws_iot_thing_group: Reduce visibility.
15016f9
@ewbankkit
r/aws_iot_topic_rule_destination: Reduce visibility.
aeda792
@ewbankkit
r/aws_iot_topic_rule: Reduce visibility.
50211d8
@ewbankkit
iot: Fixup sweepers.
2f1afa8
@ewbankkit
Fix golangci-lint 'exportloopref'.
90d5d0b
@ewbankkit
r/aws_iot_role_alias: Handle ResourceNotFound on Delete.
992fbd3
ewbankkit
ewbankkit approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIoT' PKG=iot ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/iot/... -v -count 1 -parallel 3  -run=TestAccIoT -timeout 360m
=== RUN   TestAccIoTAuthorizer_basic
=== PAUSE TestAccIoTAuthorizer_basic
=== RUN   TestAccIoTAuthorizer_disappears
=== PAUSE TestAccIoTAuthorizer_disappears
=== RUN   TestAccIoTAuthorizer_signingDisabled
=== PAUSE TestAccIoTAuthorizer_signingDisabled
=== RUN   TestAccIoTAuthorizer_update
=== PAUSE TestAccIoTAuthorizer_update
=== RUN   TestAccIoTAuthorizer_tags
=== PAUSE TestAccIoTAuthorizer_tags
=== RUN   TestAccIoTBillingGroup_basic
=== PAUSE TestAccIoTBillingGroup_basic
=== RUN   TestAccIoTBillingGroup_disappears
=== PAUSE TestAccIoTBillingGroup_disappears
=== RUN   TestAccIoTBillingGroup_tags
=== PAUSE TestAccIoTBillingGroup_tags
=== RUN   TestAccIoTBillingGroup_properties
=== PAUSE TestAccIoTBillingGroup_properties
=== RUN   TestAccIoTCACertificate_basic
=== PAUSE TestAccIoTCACertificate_basic
=== RUN   TestAccIoTCACertificate_disappears
=== PAUSE TestAccIoTCACertificate_disappears
=== RUN   TestAccIoTCACertificate_tags
=== PAUSE TestAccIoTCACertificate_tags
=== RUN   TestAccIoTCACertificate_defaultMode
=== PAUSE TestAccIoTCACertificate_defaultMode
=== RUN   TestAccIoTCACertificate_registrationConfig
=== PAUSE TestAccIoTCACertificate_registrationConfig
=== RUN   TestAccIoTCertificate_csr
=== PAUSE TestAccIoTCertificate_csr
=== RUN   TestAccIoTCertificate_Keys_certificate
=== PAUSE TestAccIoTCertificate_Keys_certificate
=== RUN   TestAccIoTCertificate_Keys_existingCertificate
=== PAUSE TestAccIoTCertificate_Keys_existingCertificate
=== RUN   TestAccIoTDomainConfiguration_basic
    domain_configuration_test.go:24: Environment variable ACM_CERTIFICATE_ROOT_DOMAIN is not set. For DNS validation requests, this domain must be publicly accessible and configurable via Route53 during the testing. For email validation requests, you must have access to one of the five standard email addresses used (admin|administrator|hostmaster|postmaster|webmaster)@domain or one of the WHOIS contact addresses.
--- SKIP: TestAccIoTDomainConfiguration_basic (0.00s)
=== RUN   TestAccIoTDomainConfiguration_disappears
    domain_configuration_test.go:64: Environment variable ACM_CERTIFICATE_ROOT_DOMAIN is not set. For DNS validation requests, this domain must be publicly accessible and configurable via Route53 during the testing. For email validation requests, you must have access to one of the five standard email addresses used (admin|administrator|hostmaster|postmaster|webmaster)@domain or one of the WHOIS contact addresses.
--- SKIP: TestAccIoTDomainConfiguration_disappears (0.00s)
=== RUN   TestAccIoTDomainConfiguration_tags
    domain_configuration_test.go:90: Environment variable ACM_CERTIFICATE_ROOT_DOMAIN is not set. For DNS validation requests, this domain must be publicly accessible and configurable via Route53 during the testing. For email validation requests, you must have access to one of the five standard email addresses used (admin|administrator|hostmaster|postmaster|webmaster)@domain or one of the WHOIS contact addresses.
--- SKIP: TestAccIoTDomainConfiguration_tags (0.00s)
=== RUN   TestAccIoTDomainConfiguration_update
    domain_configuration_test.go:137: Environment variable ACM_CERTIFICATE_ROOT_DOMAIN is not set. For DNS validation requests, this domain must be publicly accessible and configurable via Route53 during the testing. For email validation requests, you must have access to one of the five standard email addresses used (admin|administrator|hostmaster|postmaster|webmaster)@domain or one of the WHOIS contact addresses.
--- SKIP: TestAccIoTDomainConfiguration_update (0.00s)
=== RUN   TestAccIoTDomainConfiguration_awsManaged
    domain_configuration_test.go:181: Environment variable IOT_DOMAIN_CONFIGURATION_TEST_AWS_MANAGED is not set, skipping test
--- SKIP: TestAccIoTDomainConfiguration_awsManaged (0.00s)
=== RUN   TestAccIoTEndpointDataSource_basic
=== PAUSE TestAccIoTEndpointDataSource_basic
=== RUN   TestAccIoTEndpointDataSource_EndpointType_iotCredentialProvider
=== PAUSE TestAccIoTEndpointDataSource_EndpointType_iotCredentialProvider
=== RUN   TestAccIoTEndpointDataSource_EndpointType_iotData
=== PAUSE TestAccIoTEndpointDataSource_EndpointType_iotData
=== RUN   TestAccIoTEndpointDataSource_EndpointType_iotDataATS
=== PAUSE TestAccIoTEndpointDataSource_EndpointType_iotDataATS
=== RUN   TestAccIoTEndpointDataSource_EndpointType_iotJobs
=== PAUSE TestAccIoTEndpointDataSource_EndpointType_iotJobs
=== RUN   TestAccIoTEventConfigurations_serial
=== PAUSE TestAccIoTEventConfigurations_serial
=== RUN   TestAccIoTIndexingConfiguration_serial
=== PAUSE TestAccIoTIndexingConfiguration_serial
=== RUN   TestAccIoTLoggingOptions_serial
=== PAUSE TestAccIoTLoggingOptions_serial
=== RUN   TestAccIoTPolicyAttachment_basic
=== PAUSE TestAccIoTPolicyAttachment_basic
=== RUN   TestAccIoTPolicy_basic
=== PAUSE TestAccIoTPolicy_basic
=== RUN   TestAccIoTPolicy_disappears
=== PAUSE TestAccIoTPolicy_disappears
=== RUN   TestAccIoTPolicy_tags
=== PAUSE TestAccIoTPolicy_tags
=== RUN   TestAccIoTPolicy_update
=== PAUSE TestAccIoTPolicy_update
=== RUN   TestAccIoTPolicy_prune
=== PAUSE TestAccIoTPolicy_prune
=== RUN   TestAccIoTProvisioningTemplate_basic
=== PAUSE TestAccIoTProvisioningTemplate_basic
=== RUN   TestAccIoTProvisioningTemplate_disappears
=== PAUSE TestAccIoTProvisioningTemplate_disappears
=== RUN   TestAccIoTProvisioningTemplate_tags
=== PAUSE TestAccIoTProvisioningTemplate_tags
=== RUN   TestAccIoTProvisioningTemplate_update
=== PAUSE TestAccIoTProvisioningTemplate_update
=== RUN   TestAccIoTRegistrationCodeDataSource_basic
=== PAUSE TestAccIoTRegistrationCodeDataSource_basic
=== RUN   TestAccIoTRoleAlias_basic
=== PAUSE TestAccIoTRoleAlias_basic
=== RUN   TestAccIoTRoleAlias_disappears
=== PAUSE TestAccIoTRoleAlias_disappears
=== RUN   TestAccIoTRoleAlias_tags
=== PAUSE TestAccIoTRoleAlias_tags
=== RUN   TestAccIoTThingGroupMembership_basic
=== PAUSE TestAccIoTThingGroupMembership_basic
=== RUN   TestAccIoTThingGroupMembership_disappears
=== PAUSE TestAccIoTThingGroupMembership_disappears
=== RUN   TestAccIoTThingGroupMembership_disappears_Thing
=== PAUSE TestAccIoTThingGroupMembership_disappears_Thing
=== RUN   TestAccIoTThingGroupMembership_disappears_ThingGroup
=== PAUSE TestAccIoTThingGroupMembership_disappears_ThingGroup
=== RUN   TestAccIoTThingGroupMembership_overrideDynamicGroup
=== PAUSE TestAccIoTThingGroupMembership_overrideDynamicGroup
=== RUN   TestAccIoTThingGroup_basic
=== PAUSE TestAccIoTThingGroup_basic
=== RUN   TestAccIoTThingGroup_disappears
=== PAUSE TestAccIoTThingGroup_disappears
=== RUN   TestAccIoTThingGroup_tags
=== PAUSE TestAccIoTThingGroup_tags
=== RUN   TestAccIoTThingGroup_parentGroup
=== PAUSE TestAccIoTThingGroup_parentGroup
=== RUN   TestAccIoTThingGroup_properties
=== PAUSE TestAccIoTThingGroup_properties
=== RUN   TestAccIoTThingPrincipalAttachment_basic
=== PAUSE TestAccIoTThingPrincipalAttachment_basic
=== RUN   TestAccIoTThing_basic
=== PAUSE TestAccIoTThing_basic
=== RUN   TestAccIoTThing_full
=== PAUSE TestAccIoTThing_full
=== RUN   TestAccIoTThingType_basic
=== PAUSE TestAccIoTThingType_basic
=== RUN   TestAccIoTThingType_disappears
=== PAUSE TestAccIoTThingType_disappears
=== RUN   TestAccIoTThingType_full
=== PAUSE TestAccIoTThingType_full
=== RUN   TestAccIoTThingType_tags
=== PAUSE TestAccIoTThingType_tags
=== RUN   TestAccIoTTopicRuleDestination_basic
=== PAUSE TestAccIoTTopicRuleDestination_basic
=== RUN   TestAccIoTTopicRuleDestination_disappears
=== PAUSE TestAccIoTTopicRuleDestination_disappears
=== RUN   TestAccIoTTopicRuleDestination_enabled
=== PAUSE TestAccIoTTopicRuleDestination_enabled
=== RUN   TestAccIoTTopicRule_basic
=== PAUSE TestAccIoTTopicRule_basic
=== RUN   TestAccIoTTopicRule_disappears
=== PAUSE TestAccIoTTopicRule_disappears
=== RUN   TestAccIoTTopicRule_tags
=== PAUSE TestAccIoTTopicRule_tags
=== RUN   TestAccIoTTopicRule_cloudWatchAlarm
=== PAUSE TestAccIoTTopicRule_cloudWatchAlarm
=== RUN   TestAccIoTTopicRule_cloudWatchLogs
=== PAUSE TestAccIoTTopicRule_cloudWatchLogs
=== RUN   TestAccIoTTopicRule_cloudWatchMetric
=== PAUSE TestAccIoTTopicRule_cloudWatchMetric
=== RUN   TestAccIoTTopicRule_dynamoDB
=== PAUSE TestAccIoTTopicRule_dynamoDB
=== RUN   TestAccIoTTopicRule_dynamoDBv2
=== PAUSE TestAccIoTTopicRule_dynamoDBv2
=== RUN   TestAccIoTTopicRule_elasticSearch
=== PAUSE TestAccIoTTopicRule_elasticSearch
=== RUN   TestAccIoTTopicRule_firehose
=== PAUSE TestAccIoTTopicRule_firehose
=== RUN   TestAccIoTTopicRule_Firehose_separator
=== PAUSE TestAccIoTTopicRule_Firehose_separator
=== RUN   TestAccIoTTopicRule_Firehose_batch_mode
=== PAUSE TestAccIoTTopicRule_Firehose_batch_mode
=== RUN   TestAccIoTTopicRule_http
=== PAUSE TestAccIoTTopicRule_http
=== RUN   TestAccIoTTopicRule_IoT_analytics
=== PAUSE TestAccIoTTopicRule_IoT_analytics
=== RUN   TestAccIoTTopicRule_IoT_analytics_batch_mode
=== PAUSE TestAccIoTTopicRule_IoT_analytics_batch_mode
=== RUN   TestAccIoTTopicRule_IoT_events
=== PAUSE TestAccIoTTopicRule_IoT_events
=== RUN   TestAccIoTTopicRule_IoT_events_batch_mode
=== PAUSE TestAccIoTTopicRule_IoT_events_batch_mode
=== RUN   TestAccIoTTopicRule_kafka
=== PAUSE TestAccIoTTopicRule_kafka
=== RUN   TestAccIoTTopicRule_kinesis
=== PAUSE TestAccIoTTopicRule_kinesis
=== RUN   TestAccIoTTopicRule_lambda
=== PAUSE TestAccIoTTopicRule_lambda
=== RUN   TestAccIoTTopicRule_republish
=== PAUSE TestAccIoTTopicRule_republish
=== RUN   TestAccIoTTopicRule_republishWithQos
=== PAUSE TestAccIoTTopicRule_republishWithQos
=== RUN   TestAccIoTTopicRule_s3
=== PAUSE TestAccIoTTopicRule_s3
=== RUN   TestAccIoTTopicRule_sns
=== PAUSE TestAccIoTTopicRule_sns
=== RUN   TestAccIoTTopicRule_sqs
=== PAUSE TestAccIoTTopicRule_sqs
=== RUN   TestAccIoTTopicRule_Step_functions
=== PAUSE TestAccIoTTopicRule_Step_functions
=== RUN   TestAccIoTTopicRule_Timestream
=== PAUSE TestAccIoTTopicRule_Timestream
=== RUN   TestAccIoTTopicRule_errorAction
=== PAUSE TestAccIoTTopicRule_errorAction
=== RUN   TestAccIoTTopicRule_updateKinesisErrorAction
=== PAUSE TestAccIoTTopicRule_updateKinesisErrorAction
=== CONT  TestAccIoTAuthorizer_basic
=== CONT  TestAccIoTThingGroup_basic
=== CONT  TestAccIoTTopicRule_dynamoDBv2
--- PASS: TestAccIoTThingGroup_basic (13.35s)
=== CONT  TestAccIoTEventConfigurations_serial
=== RUN   TestAccIoTEventConfigurations_serial/basic
--- PASS: TestAccIoTEventConfigurations_serial (11.63s)
    --- PASS: TestAccIoTEventConfigurations_serial/basic (11.63s)
=== CONT  TestAccIoTThingGroupMembership_overrideDynamicGroup
--- PASS: TestAccIoTTopicRule_dynamoDBv2 (29.37s)
=== CONT  TestAccIoTThingGroupMembership_disappears_ThingGroup
--- PASS: TestAccIoTAuthorizer_basic (30.45s)
=== CONT  TestAccIoTThingGroupMembership_disappears_Thing
--- PASS: TestAccIoTThingGroupMembership_overrideDynamicGroup (12.77s)
=== CONT  TestAccIoTThingGroupMembership_disappears
--- PASS: TestAccIoTThingGroupMembership_disappears_ThingGroup (10.78s)
=== CONT  TestAccIoTThingGroupMembership_basic
--- PASS: TestAccIoTThingGroupMembership_disappears_Thing (11.07s)
=== CONT  TestAccIoTRoleAlias_tags
--- PASS: TestAccIoTThingGroupMembership_disappears (10.98s)
=== CONT  TestAccIoTRoleAlias_disappears
--- PASS: TestAccIoTThingGroupMembership_basic (12.87s)
=== CONT  TestAccIoTRoleAlias_basic
--- PASS: TestAccIoTRoleAlias_disappears (12.06s)
=== CONT  TestAccIoTRegistrationCodeDataSource_basic
--- PASS: TestAccIoTRegistrationCodeDataSource_basic (7.46s)
=== CONT  TestAccIoTProvisioningTemplate_update
--- PASS: TestAccIoTRoleAlias_tags (31.20s)
=== CONT  TestAccIoTProvisioningTemplate_tags
--- PASS: TestAccIoTRoleAlias_basic (52.60s)
=== CONT  TestAccIoTProvisioningTemplate_disappears
--- PASS: TestAccIoTProvisioningTemplate_tags (39.37s)
=== CONT  TestAccIoTProvisioningTemplate_basic
--- PASS: TestAccIoTProvisioningTemplate_update (46.47s)
=== CONT  TestAccIoTPolicy_prune
--- PASS: TestAccIoTProvisioningTemplate_disappears (19.62s)
=== CONT  TestAccIoTPolicy_update
--- PASS: TestAccIoTProvisioningTemplate_basic (21.61s)
=== CONT  TestAccIoTPolicy_tags
--- PASS: TestAccIoTPolicy_update (20.83s)
=== CONT  TestAccIoTPolicy_disappears
--- PASS: TestAccIoTPolicy_disappears (10.64s)
=== CONT  TestAccIoTPolicy_basic
--- PASS: TestAccIoTPolicy_tags (28.93s)
=== CONT  TestAccIoTPolicyAttachment_basic
--- PASS: TestAccIoTPolicy_basic (12.64s)
=== CONT  TestAccIoTLoggingOptions_serial
=== RUN   TestAccIoTLoggingOptions_serial/basic
--- PASS: TestAccIoTPolicy_prune (59.83s)
=== CONT  TestAccIoTIndexingConfiguration_serial
=== RUN   TestAccIoTIndexingConfiguration_serial/basic
=== RUN   TestAccIoTIndexingConfiguration_serial/allAttributes
=== RUN   TestAccIoTLoggingOptions_serial/update
--- PASS: TestAccIoTIndexingConfiguration_serial (24.02s)
    --- PASS: TestAccIoTIndexingConfiguration_serial/basic (11.59s)
    --- PASS: TestAccIoTIndexingConfiguration_serial/allAttributes (12.43s)
=== CONT  TestAccIoTTopicRule_kinesis
--- PASS: TestAccIoTPolicyAttachment_basic (36.26s)
=== CONT  TestAccIoTTopicRule_updateKinesisErrorAction
--- PASS: TestAccIoTLoggingOptions_serial (46.11s)
    --- PASS: TestAccIoTLoggingOptions_serial/basic (18.83s)
    --- PASS: TestAccIoTLoggingOptions_serial/update (27.27s)
=== CONT  TestAccIoTTopicRule_errorAction
--- PASS: TestAccIoTTopicRule_kinesis (31.25s)
=== CONT  TestAccIoTTopicRule_Timestream
--- PASS: TestAccIoTTopicRule_updateKinesisErrorAction (31.06s)
=== CONT  TestAccIoTTopicRule_Step_functions
--- PASS: TestAccIoTTopicRule_errorAction (22.11s)
=== CONT  TestAccIoTTopicRule_sqs
--- PASS: TestAccIoTTopicRule_Timestream (31.94s)
=== CONT  TestAccIoTTopicRule_sns
--- PASS: TestAccIoTTopicRule_Step_functions (31.49s)
=== CONT  TestAccIoTTopicRule_s3
--- PASS: TestAccIoTTopicRule_sqs (31.70s)
=== CONT  TestAccIoTTopicRule_republishWithQos
--- PASS: TestAccIoTTopicRule_republishWithQos (21.99s)
=== CONT  TestAccIoTTopicRule_republish
--- PASS: TestAccIoTTopicRule_sns (32.19s)
=== CONT  TestAccIoTTopicRule_lambda
--- PASS: TestAccIoTTopicRule_s3 (32.26s)
=== CONT  TestAccIoTTopicRule_IoT_analytics
--- PASS: TestAccIoTTopicRule_lambda (12.91s)
=== CONT  TestAccIoTTopicRule_kafka
--- PASS: TestAccIoTTopicRule_IoT_analytics (28.85s)
=== CONT  TestAccIoTTopicRule_IoT_events_batch_mode
--- PASS: TestAccIoTTopicRule_republish (31.45s)
=== CONT  TestAccIoTTopicRule_IoT_events
--- PASS: TestAccIoTTopicRule_IoT_events (19.80s)
=== CONT  TestAccIoTTopicRule_IoT_analytics_batch_mode
--- PASS: TestAccIoTTopicRule_IoT_events_batch_mode (28.96s)
=== CONT  TestAccIoTCACertificate_tags
--- PASS: TestAccIoTTopicRule_kafka (48.42s)
=== CONT  TestAccIoTEndpointDataSource_EndpointType_iotJobs
--- PASS: TestAccIoTEndpointDataSource_EndpointType_iotJobs (7.69s)
=== CONT  TestAccIoTEndpointDataSource_EndpointType_iotDataATS
--- PASS: TestAccIoTEndpointDataSource_EndpointType_iotDataATS (7.58s)
=== CONT  TestAccIoTEndpointDataSource_EndpointType_iotData
--- PASS: TestAccIoTTopicRule_IoT_analytics_batch_mode (28.79s)
=== CONT  TestAccIoTEndpointDataSource_EndpointType_iotCredentialProvider
--- PASS: TestAccIoTEndpointDataSource_EndpointType_iotData (7.46s)
=== CONT  TestAccIoTEndpointDataSource_basic
--- PASS: TestAccIoTCACertificate_tags (26.46s)
=== CONT  TestAccIoTCertificate_Keys_existingCertificate
--- PASS: TestAccIoTEndpointDataSource_EndpointType_iotCredentialProvider (7.61s)
=== CONT  TestAccIoTCertificate_Keys_certificate
--- PASS: TestAccIoTEndpointDataSource_basic (7.59s)
=== CONT  TestAccIoTCertificate_csr
--- PASS: TestAccIoTCertificate_Keys_certificate (10.19s)
--- PASS: TestAccIoTCACertificate_registrationConfig (25.31s)
=== CONT  TestAccIoTCACertificate_defaultMode
--- PASS: TestAccIoTCACertificate_defaultMode (25.11s)
=== CONT  TestAccIoTBillingGroup_disappears
--- PASS: TestAccIoTCertificate_csr (10.40s)
=== CONT  TestAccIoTCACertificate_disappears
--- PASS: TestAccIoTCertificate_Keys_existingCertificate (17.98s)
=== CONT  TestAccIoTCACertificate_basic
--- PASS: TestAccIoTBillingGroup_disappears (10.65s)
=== CONT  TestAccIoTBillingGroup_properties
--- PASS: TestAccIoTCACertificate_basic (10.50s)
=== CONT  TestAccIoTBillingGroup_tags
--- PASS: TestAccIoTCACertificate_disappears (10.90s)
=== CONT  TestAccIoTTopicRule_Firehose_separator
--- PASS: TestAccIoTBillingGroup_properties (20.59s)
=== CONT  TestAccIoTTopicRule_http
--- PASS: TestAccIoTBillingGroup_tags (28.62s)
=== CONT  TestAccIoTTopicRule_Firehose_batch_mode
--- PASS: TestAccIoTTopicRule_Firehose_separator (31.36s)
=== CONT  TestAccIoTThingType_tags
--- PASS: TestAccIoTTopicRule_http (38.17s)
=== CONT  TestAccIoTTopicRule_dynamoDB
--- PASS: TestAccIoTTopicRule_Firehose_batch_mode (31.22s)
=== CONT  TestAccIoTTopicRule_cloudWatchMetric
--- PASS: TestAccIoTTopicRule_dynamoDB (31.00s)
=== CONT  TestAccIoTTopicRule_cloudWatchLogs
--- PASS: TestAccIoTTopicRule_cloudWatchMetric (30.96s)
=== CONT  TestAccIoTTopicRule_cloudWatchAlarm
--- PASS: TestAccIoTTopicRule_cloudWatchLogs (31.13s)
=== CONT  TestAccIoTTopicRule_tags
--- PASS: TestAccIoTTopicRule_cloudWatchAlarm (31.61s)
=== CONT  TestAccIoTTopicRule_disappears
--- PASS: TestAccIoTTopicRule_disappears (10.79s)
=== CONT  TestAccIoTTopicRule_basic
--- PASS: TestAccIoTTopicRule_tags (29.47s)
=== CONT  TestAccIoTTopicRuleDestination_enabled
--- PASS: TestAccIoTTopicRule_basic (12.80s)
=== CONT  TestAccIoTTopicRuleDestination_disappears
--- PASS: TestAccIoTThingType_tags (328.77s)
=== CONT  TestAccIoTTopicRuleDestination_basic
--- PASS: TestAccIoTTopicRuleDestination_basic (370.82s)
=== CONT  TestAccIoTThing_basic
--- PASS: TestAccIoTThing_basic (12.98s)
=== CONT  TestAccIoTThingType_full
--- PASS: TestAccIoTTopicRuleDestination_disappears (645.14s)
=== CONT  TestAccIoTThingType_disappears
--- PASS: TestAccIoTThingType_full (330.59s)
=== CONT  TestAccIoTThingType_basic
--- PASS: TestAccIoTThingType_disappears (320.47s)
=== CONT  TestAccIoTThing_full
--- PASS: TestAccIoTThingType_basic (313.07s)
=== CONT  TestAccIoTAuthorizer_update
--- PASS: TestAccIoTThing_full (298.86s)
=== CONT  TestAccIoTBillingGroup_basic
--- PASS: TestAccIoTBillingGroup_basic (14.22s)
=== CONT  TestAccIoTAuthorizer_tags
--- PASS: TestAccIoTAuthorizer_update (39.25s)
=== CONT  TestAccIoTThingPrincipalAttachment_basic
--- PASS: TestAccIoTTopicRuleDestination_enabled (1287.08s)
=== CONT  TestAccIoTTopicRule_firehose
--- PASS: TestAccIoTTopicRule_firehose (32.33s)
=== CONT  TestAccIoTThingGroup_tags
--- PASS: TestAccIoTThingPrincipalAttachment_basic (46.00s)
=== CONT  TestAccIoTThingGroup_disappears
--- PASS: TestAccIoTAuthorizer_tags (51.56s)
=== CONT  TestAccIoTThingGroup_properties
--- PASS: TestAccIoTThingGroup_disappears (10.94s)
=== CONT  TestAccIoTTopicRule_elasticSearch
--- PASS: TestAccIoTThingGroup_tags (29.61s)
=== CONT  TestAccIoTAuthorizer_signingDisabled
--- PASS: TestAccIoTThingGroup_properties (21.07s)
=== CONT  TestAccIoTAuthorizer_disappears
--- PASS: TestAccIoTTopicRule_elasticSearch (31.43s)
=== CONT  TestAccIoTThingGroup_parentGroup
--- PASS: TestAccIoTAuthorizer_signingDisabled (29.25s)
--- PASS: TestAccIoTAuthorizer_disappears (29.87s)
--- PASS: TestAccIoTThingGroup_parentGroup (15.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	1942.303s

@ewbankkit ewbankkit added bug Addresses a defect in current functionality. enhancement Requests to existing resources that expand the functionality or scope. labels Jul 2, 2024
@ewbankkit
Copy link
Contributor

@DanielRieske Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 9ca5688 into hashicorp:main Jul 2, 2024
71 checks passed
@github-actions github-actions bot added this to the v5.57.0 milestone Jul 2, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

This functionality has been released in v5.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit ewbankkit mentioned this pull request Aug 1, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. bug Addresses a defect in current functionality. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. github_actions Pull requests that update Github_actions code repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/greengrass Issues and PRs that pertain to the greengrass service. service/iot Issues and PRs that pertain to the iot service. service/iotanalytics Issues and PRs that pertain to the iotanalytics service. service/iotevents Issues and PRs that pertain to the iotevents service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.57.0
3 participants
@DanielRieske @ewbankkit @justinretzolk