directconnect: Migrate to AWS SDK v2 #37213

mattburgess · 2024-05-01T21:39:43Z

Description

Relations

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

github-actions · 2024-05-01T21:39:57Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

github-actions · 2024-05-01T21:40:18Z

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

Check open pull requests with the dependencies label to view other dependency updates.
If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
If this pull request is for supporting a new AWS service:
- Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
- If this pull request is already a separate pull request from the above item, you can ignore this message.

# Conflicts: # go.mod # go.sum # internal/conns/awsclient_gen.go # internal/service/directconnect/gateway.go # internal/service/directconnect/gateway_data_source.go # internal/service/directconnect/hosted_connection.go # internal/service/directconnect/hosted_private_virtual_interface.go # internal/service/directconnect/hosted_private_virtual_interface_test.go # internal/service/directconnect/hosted_public_virtual_interface.go # internal/service/directconnect/hosted_public_virtual_interface_test.go # internal/service/directconnect/hosted_transit_virtual_interface.go # internal/service/directconnect/hosted_transit_virtual_interface_test.go # internal/service/directconnect/private_virtual_interface.go # internal/service/directconnect/private_virtual_interface_test.go # internal/service/directconnect/public_virtual_interface.go # internal/service/directconnect/public_virtual_interface_test.go # internal/service/directconnect/service_endpoints_gen_test.go # internal/service/directconnect/service_package_gen.go # internal/service/directconnect/sweep.go # internal/service/directconnect/transit_virtual_interface.go # internal/service/directconnect/transit_virtual_interface_test.go # names/data/names_data.csv # names/names.go

…se' - appautoscaling.

…se' - appsync.

…se' - backup.

…se' - codeartifact.

…se' - configservice.

…se' - devicefarm.

…se' - ec2.

…se' - elasticache.

…se' - elbv2.

…se' - rds.

…se' - s3.

…se' - ssm.

…se' - storagegateway.

…tewayv2.

…toidentity.

…gegateway.

…gional.

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDirectConnect' PKG=directconnect ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/directconnect/... -v -count 1 -parallel 3  -run=TestAccDirectConnect -timeout 360m
=== RUN   TestAccDirectConnectBGPPeer_basic
    bgp_peer_test.go:25: Environment variable DX_VIRTUAL_INTERFACE_ID is not set, skipping test
--- SKIP: TestAccDirectConnectBGPPeer_basic (0.00s)
=== RUN   TestAccDirectConnectBGPPeer_disappears
    bgp_peer_test.go:48: Environment variable DX_VIRTUAL_INTERFACE_ID is not set, skipping test
--- SKIP: TestAccDirectConnectBGPPeer_disappears (0.00s)
=== RUN   TestAccDirectConnectConnectionAssociation_basic
=== PAUSE TestAccDirectConnectConnectionAssociation_basic
=== RUN   TestAccDirectConnectConnectionAssociation_disappears
=== PAUSE TestAccDirectConnectConnectionAssociation_disappears
=== RUN   TestAccDirectConnectConnectionAssociation_lagOnConnection
=== PAUSE TestAccDirectConnectConnectionAssociation_lagOnConnection
=== RUN   TestAccDirectConnectConnectionAssociation_multiple
=== PAUSE TestAccDirectConnectConnectionAssociation_multiple
=== RUN   TestAccDirectConnectConnectionConfirmation_basic
    connection_confirmation_test.go:24: Environment variable TEST_AWS_DX_CONNECTION_ID is not set, skipping test
--- SKIP: TestAccDirectConnectConnectionConfirmation_basic (0.00s)
=== RUN   TestAccDirectConnectConnectionDataSource_basic
=== PAUSE TestAccDirectConnectConnectionDataSource_basic
=== RUN   TestAccDirectConnectConnection_basic
=== PAUSE TestAccDirectConnectConnection_basic
=== RUN   TestAccDirectConnectConnection_disappears
=== PAUSE TestAccDirectConnectConnection_disappears
=== RUN   TestAccDirectConnectConnection_encryptionMode
    connection_test.go:86: Environment variable DX_CONNECTION_ID is not set, skipping test
--- SKIP: TestAccDirectConnectConnection_encryptionMode (0.00s)
=== RUN   TestAccDirectConnectConnection_macsecRequested
=== PAUSE TestAccDirectConnectConnection_macsecRequested
=== RUN   TestAccDirectConnectConnection_providerName
=== PAUSE TestAccDirectConnectConnection_providerName
=== RUN   TestAccDirectConnectConnection_skipDestroy
=== PAUSE TestAccDirectConnectConnection_skipDestroy
=== RUN   TestAccDirectConnectConnection_tags
=== PAUSE TestAccDirectConnectConnection_tags
=== RUN   TestAccDirectConnectConnection_vlanIDMigration501
=== PAUSE TestAccDirectConnectConnection_vlanIDMigration501
=== RUN   TestAccDirectConnectConnection_vlanIDMigration510
=== PAUSE TestAccDirectConnectConnection_vlanIDMigration510
=== RUN   TestAccDirectConnectGatewayAssociationProposal_basicVPNGateway
=== PAUSE TestAccDirectConnectGatewayAssociationProposal_basicVPNGateway
=== RUN   TestAccDirectConnectGatewayAssociationProposal_basicTransitGateway
=== PAUSE TestAccDirectConnectGatewayAssociationProposal_basicTransitGateway
=== RUN   TestAccDirectConnectGatewayAssociationProposal_disappears
=== PAUSE TestAccDirectConnectGatewayAssociationProposal_disappears
=== RUN   TestAccDirectConnectGatewayAssociationProposal_endOfLifeVPN
=== PAUSE TestAccDirectConnectGatewayAssociationProposal_endOfLifeVPN
=== RUN   TestAccDirectConnectGatewayAssociationProposal_endOfLifeTgw
=== PAUSE TestAccDirectConnectGatewayAssociationProposal_endOfLifeTgw
=== RUN   TestAccDirectConnectGatewayAssociationProposal_allowedPrefixes
=== PAUSE TestAccDirectConnectGatewayAssociationProposal_allowedPrefixes
=== RUN   TestAccDirectConnectGatewayAssociation_v0StateUpgrade
=== PAUSE TestAccDirectConnectGatewayAssociation_v0StateUpgrade
=== RUN   TestAccDirectConnectGatewayAssociation_basicVPNGatewaySingleAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_basicVPNGatewaySingleAccount
=== RUN   TestAccDirectConnectGatewayAssociation_basicVPNGatewayCrossAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_basicVPNGatewayCrossAccount
=== RUN   TestAccDirectConnectGatewayAssociation_basicTransitGatewaySingleAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_basicTransitGatewaySingleAccount
=== RUN   TestAccDirectConnectGatewayAssociation_basicTransitGatewayCrossAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_basicTransitGatewayCrossAccount
=== RUN   TestAccDirectConnectGatewayAssociation_multiVPNGatewaysSingleAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_multiVPNGatewaysSingleAccount
=== RUN   TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewaySingleAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewaySingleAccount
=== RUN   TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewayCrossAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewayCrossAccount
=== RUN   TestAccDirectConnectGatewayAssociation_recreateProposal
=== PAUSE TestAccDirectConnectGatewayAssociation_recreateProposal
=== RUN   TestAccDirectConnectGatewayDataSource_basic
=== PAUSE TestAccDirectConnectGatewayDataSource_basic
=== RUN   TestAccDirectConnectGateway_basic
=== PAUSE TestAccDirectConnectGateway_basic
=== RUN   TestAccDirectConnectGateway_disappears
=== PAUSE TestAccDirectConnectGateway_disappears
=== RUN   TestAccDirectConnectGateway_complex
=== PAUSE TestAccDirectConnectGateway_complex
=== RUN   TestAccDirectConnectGateway_update
=== PAUSE TestAccDirectConnectGateway_update
=== RUN   TestAccDirectConnectHostedConnection_basic
    hosted_connection_test.go:24: Environment variable TEST_AWS_DX_CONNECTION_ID is not set, skipping test
--- SKIP: TestAccDirectConnectHostedConnection_basic (0.00s)
=== RUN   TestAccDirectConnectHostedPrivateVirtualInterface_basic
    hosted_private_virtual_interface_test.go:24: Environment variable DX_CONNECTION_ID is not set, skipping test
--- SKIP: TestAccDirectConnectHostedPrivateVirtualInterface_basic (0.00s)
=== RUN   TestAccDirectConnectHostedPrivateVirtualInterface_accepterTags
    hosted_private_virtual_interface_test.go:78: Environment variable DX_CONNECTION_ID is not set, skipping test
--- SKIP: TestAccDirectConnectHostedPrivateVirtualInterface_accepterTags (0.00s)
=== RUN   TestAccDirectConnectHostedPublicVirtualInterface_basic
    hosted_public_virtual_interface_test.go:24: Environment variable DX_CONNECTION_ID is not set, skipping test
--- SKIP: TestAccDirectConnectHostedPublicVirtualInterface_basic (0.00s)
=== RUN   TestAccDirectConnectHostedPublicVirtualInterface_accepterTags
    hosted_public_virtual_interface_test.go:80: Environment variable DX_CONNECTION_ID is not set, skipping test
--- SKIP: TestAccDirectConnectHostedPublicVirtualInterface_accepterTags (0.00s)
=== RUN   TestAccDirectConnectHostedTransitVirtualInterface_serial
=== PAUSE TestAccDirectConnectHostedTransitVirtualInterface_serial
=== RUN   TestAccDirectConnectLag_basic
=== PAUSE TestAccDirectConnectLag_basic
=== RUN   TestAccDirectConnectLag_disappears
=== PAUSE TestAccDirectConnectLag_disappears
=== RUN   TestAccDirectConnectLag_connectionID
=== PAUSE TestAccDirectConnectLag_connectionID
=== RUN   TestAccDirectConnectLag_providerName
=== PAUSE TestAccDirectConnectLag_providerName
=== RUN   TestAccDirectConnectLag_tags
=== PAUSE TestAccDirectConnectLag_tags
=== RUN   TestAccDirectConnectLocationDataSource_basic
=== PAUSE TestAccDirectConnectLocationDataSource_basic
=== RUN   TestAccDirectConnectMacSecKeyAssociation_withCkn
    macsec_key_association_test.go:25: Environment variable DX_CONNECTION_ID is not set, skipping test
--- SKIP: TestAccDirectConnectMacSecKeyAssociation_withCkn (0.00s)
=== RUN   TestAccDirectConnectMacSecKeyAssociation_withSecret
    macsec_key_association_test.go:57: Environment variable DX_CONNECTION_ID is not set, skipping test
--- SKIP: TestAccDirectConnectMacSecKeyAssociation_withSecret (0.00s)
=== RUN   TestAccDirectConnectPrivateVirtualInterface_basic
    private_virtual_interface_test.go:24: Environment variable DX_CONNECTION_ID is not set, skipping test
--- SKIP: TestAccDirectConnectPrivateVirtualInterface_basic (0.00s)
=== RUN   TestAccDirectConnectPrivateVirtualInterface_tags
    private_virtual_interface_test.go:92: Environment variable DX_CONNECTION_ID is not set, skipping test
--- SKIP: TestAccDirectConnectPrivateVirtualInterface_tags (0.00s)
=== RUN   TestAccDirectConnectPrivateVirtualInterface_dxGateway
    private_virtual_interface_test.go:166: Environment variable DX_CONNECTION_ID is not set, skipping test
--- SKIP: TestAccDirectConnectPrivateVirtualInterface_dxGateway (0.00s)
=== RUN   TestAccDirectConnectPrivateVirtualInterface_siteLink
    private_virtual_interface_test.go:214: Environment variable DX_CONNECTION_ID is not set, skipping test
--- SKIP: TestAccDirectConnectPrivateVirtualInterface_siteLink (0.00s)
=== RUN   TestAccDirectConnectPublicVirtualInterface_basic
    public_virtual_interface_test.go:24: Environment variable DX_CONNECTION_ID is not set, skipping test
--- SKIP: TestAccDirectConnectPublicVirtualInterface_basic (0.00s)
=== RUN   TestAccDirectConnectPublicVirtualInterface_tags
    public_virtual_interface_test.go:76: Environment variable DX_CONNECTION_ID is not set, skipping test
--- SKIP: TestAccDirectConnectPublicVirtualInterface_tags (0.00s)
=== RUN   TestAccDirectConnectRouterConfigurationDataSource_basic
    router_configuration_data_source_test.go:17: Environment variable VIRTUAL_INTERFACE_ID is not set, skipping test
--- SKIP: TestAccDirectConnectRouterConfigurationDataSource_basic (0.00s)
=== RUN   TestAccDirectConnectTransitVirtualInterface_serial
=== PAUSE TestAccDirectConnectTransitVirtualInterface_serial
=== CONT  TestAccDirectConnectConnectionAssociation_basic
=== CONT  TestAccDirectConnectGatewayAssociation_basicVPNGatewayCrossAccount
=== CONT  TestAccDirectConnectGateway_complex
=== NAME  TestAccDirectConnectGatewayAssociation_basicVPNGatewayCrossAccount
    gateway_association_test.go:100: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccDirectConnectGatewayAssociation_basicVPNGatewayCrossAccount (0.38s)
=== CONT  TestAccDirectConnectTransitVirtualInterface_serial
=== RUN   TestAccDirectConnectTransitVirtualInterface_serial/basic
    transit_virtual_interface_test.go:36: Environment variable DX_CONNECTION_ID is not set, skipping test
=== RUN   TestAccDirectConnectTransitVirtualInterface_serial/tags
    transit_virtual_interface_test.go:105: Environment variable DX_CONNECTION_ID is not set, skipping test
=== RUN   TestAccDirectConnectTransitVirtualInterface_serial/sitelink
    transit_virtual_interface_test.go:180: Environment variable DX_CONNECTION_ID is not set, skipping test
--- PASS: TestAccDirectConnectTransitVirtualInterface_serial (0.00s)
    --- SKIP: TestAccDirectConnectTransitVirtualInterface_serial/basic (0.00s)
    --- SKIP: TestAccDirectConnectTransitVirtualInterface_serial/tags (0.00s)
    --- SKIP: TestAccDirectConnectTransitVirtualInterface_serial/sitelink (0.00s)
=== CONT  TestAccDirectConnectLocationDataSource_basic
--- PASS: TestAccDirectConnectLocationDataSource_basic (8.76s)
=== CONT  TestAccDirectConnectLag_tags
--- PASS: TestAccDirectConnectLag_tags (31.67s)
=== CONT  TestAccDirectConnectLag_providerName
--- PASS: TestAccDirectConnectConnectionAssociation_basic (13.90s)
=== CONT  TestAccDirectConnectLag_connectionID
--- PASS: TestAccDirectConnectLag_providerName (15.31s)
=== CONT  TestAccDirectConnectLag_disappears
--- PASS: TestAccDirectConnectLag_disappears (11.35s)
=== CONT  TestAccDirectConnectLag_basic
--- PASS: TestAccDirectConnectLag_basic (22.61s)
=== CONT  TestAccDirectConnectHostedTransitVirtualInterface_serial
=== RUN   TestAccDirectConnectHostedTransitVirtualInterface_serial/basic
    hosted_transit_virtual_interface_test.go:35: Environment variable DX_CONNECTION_ID is not set, skipping test
=== RUN   TestAccDirectConnectHostedTransitVirtualInterface_serial/accepterTags
    hosted_transit_virtual_interface_test.go:90: Environment variable DX_CONNECTION_ID is not set, skipping test
--- PASS: TestAccDirectConnectHostedTransitVirtualInterface_serial (0.00s)
    --- SKIP: TestAccDirectConnectHostedTransitVirtualInterface_serial/basic (0.00s)
    --- SKIP: TestAccDirectConnectHostedTransitVirtualInterface_serial/accepterTags (0.00s)
=== CONT  TestAccDirectConnectGateway_update
--- PASS: TestAccDirectConnectLag_connectionID (14.97s)
=== CONT  TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewayCrossAccount
    gateway_association_test.go:290: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewayCrossAccount (0.00s)
=== CONT  TestAccDirectConnectGateway_disappears
--- PASS: TestAccDirectConnectGateway_update (49.72s)
=== CONT  TestAccDirectConnectGateway_basic
--- PASS: TestAccDirectConnectGateway_disappears (54.15s)
=== CONT  TestAccDirectConnectGatewayDataSource_basic
--- PASS: TestAccDirectConnectGateway_basic (18.16s)
=== CONT  TestAccDirectConnectGatewayAssociation_recreateProposal
    gateway_association_test.go:333: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccDirectConnectGatewayAssociation_recreateProposal (0.00s)
=== CONT  TestAccDirectConnectGatewayAssociation_multiVPNGatewaysSingleAccount
--- PASS: TestAccDirectConnectGatewayDataSource_basic (16.05s)
=== CONT  TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewaySingleAccount
--- PASS: TestAccDirectConnectGatewayAssociation_multiVPNGatewaysSingleAccount (709.12s)
=== CONT  TestAccDirectConnectConnection_disappears
--- PASS: TestAccDirectConnectGateway_complex (805.17s)
=== CONT  TestAccDirectConnectConnection_tags
--- PASS: TestAccDirectConnectConnection_disappears (12.78s)
=== CONT  TestAccDirectConnectConnection_skipDestroy
--- PASS: TestAccDirectConnectConnection_skipDestroy (10.12s)
=== CONT  TestAccDirectConnectConnection_providerName
=== CONT  TestAccDirectConnectConnection_macsecRequested
--- PASS: TestAccDirectConnectConnection_tags (30.76s)
--- PASS: TestAccDirectConnectConnection_providerName (14.01s)
=== CONT  TestAccDirectConnectConnectionAssociation_multiple
--- PASS: TestAccDirectConnectConnection_macsecRequested (14.35s)
=== CONT  TestAccDirectConnectConnection_basic
--- PASS: TestAccDirectConnectConnectionAssociation_multiple (13.05s)
=== CONT  TestAccDirectConnectConnectionDataSource_basic
--- PASS: TestAccDirectConnectConnection_basic (14.30s)
=== CONT  TestAccDirectConnectGatewayAssociation_basicTransitGatewayCrossAccount
    gateway_association_test.go:176: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccDirectConnectGatewayAssociation_basicTransitGatewayCrossAccount (0.00s)
=== CONT  TestAccDirectConnectGatewayAssociation_basicTransitGatewaySingleAccount
--- PASS: TestAccDirectConnectConnectionDataSource_basic (11.37s)
=== CONT  TestAccDirectConnectConnectionAssociation_lagOnConnection
--- PASS: TestAccDirectConnectConnectionAssociation_lagOnConnection (13.67s)
=== CONT  TestAccDirectConnectGatewayAssociationProposal_endOfLifeVPN
    gateway_association_proposal_test.go:131: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccDirectConnectGatewayAssociationProposal_endOfLifeVPN (0.00s)
=== CONT  TestAccDirectConnectGatewayAssociation_basicVPNGatewaySingleAccount
--- PASS: TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewaySingleAccount (1103.51s)
=== CONT  TestAccDirectConnectGatewayAssociation_v0StateUpgrade
--- PASS: TestAccDirectConnectGatewayAssociation_basicTransitGatewaySingleAccount (1281.10s)
=== CONT  TestAccDirectConnectGatewayAssociationProposal_allowedPrefixes
    gateway_association_proposal_test.go:205: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccDirectConnectGatewayAssociationProposal_allowedPrefixes (0.00s)
=== CONT  TestAccDirectConnectGatewayAssociationProposal_endOfLifeTgw
    gateway_association_proposal_test.go:168: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccDirectConnectGatewayAssociationProposal_endOfLifeTgw (0.00s)
=== CONT  TestAccDirectConnectConnectionAssociation_disappears
--- PASS: TestAccDirectConnectConnectionAssociation_disappears (16.02s)
=== CONT  TestAccDirectConnectGatewayAssociationProposal_basicTransitGateway
    gateway_association_proposal_test.go:70: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccDirectConnectGatewayAssociationProposal_basicTransitGateway (0.00s)
=== CONT  TestAccDirectConnectGatewayAssociationProposal_disappears
    gateway_association_proposal_test.go:106: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccDirectConnectGatewayAssociationProposal_disappears (0.00s)
=== CONT  TestAccDirectConnectGatewayAssociationProposal_basicVPNGateway
    gateway_association_proposal_test.go:34: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccDirectConnectGatewayAssociationProposal_basicVPNGateway (0.00s)
=== CONT  TestAccDirectConnectConnection_vlanIDMigration510
--- PASS: TestAccDirectConnectConnection_vlanIDMigration510 (36.69s)
=== CONT  TestAccDirectConnectConnection_vlanIDMigration501
--- PASS: TestAccDirectConnectConnection_vlanIDMigration501 (37.88s)
--- PASS: TestAccDirectConnectGatewayAssociation_basicVPNGatewaySingleAccount (1445.79s)
--- PASS: TestAccDirectConnectGatewayAssociation_v0StateUpgrade (1360.75s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/directconnect	2568.355s

% make testacc TESTARGS='-run=TestAccDirectConnectGatewayAssociation_\|TestAccDirectConnectGatewayAssociationProposal_' PKG=directconnect ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/directconnect/... -v -count 1 -parallel 3  -run=TestAccDirectConnectGatewayAssociation_\|TestAccDirectConnectGatewayAssociationProposal_ -timeout 360m
=== RUN   TestAccDirectConnectGatewayAssociationProposal_basicVPNGateway
=== PAUSE TestAccDirectConnectGatewayAssociationProposal_basicVPNGateway
=== RUN   TestAccDirectConnectGatewayAssociationProposal_basicTransitGateway
=== PAUSE TestAccDirectConnectGatewayAssociationProposal_basicTransitGateway
=== RUN   TestAccDirectConnectGatewayAssociationProposal_disappears
=== PAUSE TestAccDirectConnectGatewayAssociationProposal_disappears
=== RUN   TestAccDirectConnectGatewayAssociationProposal_endOfLifeVPN
=== PAUSE TestAccDirectConnectGatewayAssociationProposal_endOfLifeVPN
=== RUN   TestAccDirectConnectGatewayAssociationProposal_endOfLifeTgw
=== PAUSE TestAccDirectConnectGatewayAssociationProposal_endOfLifeTgw
=== RUN   TestAccDirectConnectGatewayAssociationProposal_allowedPrefixes
=== PAUSE TestAccDirectConnectGatewayAssociationProposal_allowedPrefixes
=== RUN   TestAccDirectConnectGatewayAssociation_v0StateUpgrade
=== PAUSE TestAccDirectConnectGatewayAssociation_v0StateUpgrade
=== RUN   TestAccDirectConnectGatewayAssociation_basicVPNGatewaySingleAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_basicVPNGatewaySingleAccount
=== RUN   TestAccDirectConnectGatewayAssociation_basicVPNGatewayCrossAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_basicVPNGatewayCrossAccount
=== RUN   TestAccDirectConnectGatewayAssociation_basicTransitGatewaySingleAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_basicTransitGatewaySingleAccount
=== RUN   TestAccDirectConnectGatewayAssociation_basicTransitGatewayCrossAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_basicTransitGatewayCrossAccount
=== RUN   TestAccDirectConnectGatewayAssociation_multiVPNGatewaysSingleAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_multiVPNGatewaysSingleAccount
=== RUN   TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewaySingleAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewaySingleAccount
=== RUN   TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewayCrossAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewayCrossAccount
=== RUN   TestAccDirectConnectGatewayAssociation_recreateProposal
=== PAUSE TestAccDirectConnectGatewayAssociation_recreateProposal
=== CONT  TestAccDirectConnectGatewayAssociationProposal_basicVPNGateway
=== CONT  TestAccDirectConnectGatewayAssociation_basicVPNGatewayCrossAccount
=== CONT  TestAccDirectConnectGatewayAssociationProposal_endOfLifeTgw
--- PASS: TestAccDirectConnectGatewayAssociationProposal_basicVPNGateway (93.68s)
=== CONT  TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewaySingleAccount
--- PASS: TestAccDirectConnectGatewayAssociation_basicVPNGatewayCrossAccount (949.26s)
=== CONT  TestAccDirectConnectGatewayAssociation_recreateProposal
--- PASS: TestAccDirectConnectGatewayAssociationProposal_endOfLifeTgw (1166.82s)
=== CONT  TestAccDirectConnectGatewayAssociation_basicVPNGatewaySingleAccount
--- PASS: TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewaySingleAccount (1489.06s)
=== CONT  TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewayCrossAccount
--- PASS: TestAccDirectConnectGatewayAssociation_recreateProposal (1167.81s)
=== CONT  TestAccDirectConnectGatewayAssociation_v0StateUpgrade
--- PASS: TestAccDirectConnectGatewayAssociation_basicVPNGatewaySingleAccount (959.31s)
=== CONT  TestAccDirectConnectGatewayAssociationProposal_disappears
--- PASS: TestAccDirectConnectGatewayAssociationProposal_disappears (88.40s)
=== CONT  TestAccDirectConnectGatewayAssociationProposal_allowedPrefixes
--- PASS: TestAccDirectConnectGatewayAssociationProposal_allowedPrefixes (94.78s)
=== CONT  TestAccDirectConnectGatewayAssociationProposal_endOfLifeVPN
--- PASS: TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewayCrossAccount (1169.11s)
=== CONT  TestAccDirectConnectGatewayAssociationProposal_basicTransitGateway
--- PASS: TestAccDirectConnectGatewayAssociationProposal_basicTransitGateway (117.20s)
=== CONT  TestAccDirectConnectGatewayAssociation_basicTransitGatewayCrossAccount
--- PASS: TestAccDirectConnectGatewayAssociation_v0StateUpgrade (1119.68s)
=== CONT  TestAccDirectConnectGatewayAssociation_multiVPNGatewaysSingleAccount
--- PASS: TestAccDirectConnectGatewayAssociationProposal_endOfLifeVPN (1247.68s)
=== CONT  TestAccDirectConnectGatewayAssociation_basicTransitGatewaySingleAccount
--- PASS: TestAccDirectConnectGatewayAssociation_basicTransitGatewayCrossAccount (1151.95s)
--- PASS: TestAccDirectConnectGatewayAssociation_multiVPNGatewaysSingleAccount (1155.46s)
--- PASS: TestAccDirectConnectGatewayAssociation_basicTransitGatewaySingleAccount (1230.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/directconnect	4791.971s

ewbankkit · 2024-08-08T15:07:13Z

@mattburgess Thanks for the contribution 🎉 👏.

github-actions · 2024-08-09T12:17:04Z

This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2024-09-09T02:17:53Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

directconnect: Migrate to AWS SDK v2

cc940ef

terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels May 1, 2024

mattburgess added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label May 1, 2024

justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label May 2, 2024

ewbankkit added 2 commits August 1, 2024 12:38

Run 'make fix-constants PKG=directconnect'.

a3116df

ewbankkit self-assigned this Aug 1, 2024

github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 1, 2024

ewbankkit added 12 commits August 1, 2024 17:13

Fix semgrep errors.

b8fe757

r/aws_dx_bgp_peer: Tidy up.

dd9ced1

'directconnect/acc_test.go' -> 'directconnect/vif_test.go'.

5a16390

directconnect: Fix compilation errors (a3116df).

0bdbc38

r/aws_dx_connection: Migrate to AWS SDK for Go v2.

3c2a05a

r/aws_dx_connection_association: Tidy up.

85a2cbd

d/aws_dx_connection: Tidy up.

60af88d

r/aws_dx_connection_confirmation: Tidy up.

945fcdf

r/aws_dx_gateway: Tidy up.

e1e0e45

d/aws_dx_gateway: Tidy up.

9c18db3

d/aws_dx_gateway_association: Tidy up.

ec8e34a

r/aws_dx_gateway_association_proposal: Tidy up.

9036aff

ewbankkit added 22 commits August 8, 2024 10:56

Replace '+ fmt.Sprintf' in acceptance tests with 'acctest.ConfigCompo…

34e3d15

…se' - appautoscaling.

Replace '+ fmt.Sprintf' in acceptance tests with 'acctest.ConfigCompo…

9319944

…se' - appsync.

Replace '+ fmt.Sprintf' in acceptance tests with 'acctest.ConfigCompo…

9aff365

…se' - backup.

Replace '+ fmt.Sprintf' in acceptance tests with 'acctest.ConfigCompo…

7d809a4

…se' - codeartifact.

Replace '+ fmt.Sprintf' in acceptance tests with 'acctest.ConfigCompo…

aa811da

…se' - configservice.

Replace '+ fmt.Sprintf' in acceptance tests with 'acctest.ConfigCompo…

180a0d1

…se' - devicefarm.

Replace '+ fmt.Sprintf' in acceptance tests with 'acctest.ConfigCompo…

7b7af6a

…se' - ec2.

Replace '+ fmt.Sprintf' in acceptance tests with 'acctest.ConfigCompo…

2367736

…se' - elasticache.

Replace '+ fmt.Sprintf' in acceptance tests with 'acctest.ConfigCompo…

7caba11

…se' - elbv2.

Replace '+ fmt.Sprintf' in acceptance tests with 'acctest.ConfigCompo…

9a9f2b7

…se' - rds.

Replace '+ fmt.Sprintf' in acceptance tests with 'acctest.ConfigCompo…

8232b0f

…se' - s3.

Replace '+ fmt.Sprintf' in acceptance tests with 'acctest.ConfigCompo…

5e46521

…se' - ssm.

Replace '+ fmt.Sprintf' in acceptance tests with 'acctest.ConfigCompo…

68b20e2

…se' - storagegateway.

Replace '+ ' in acceptance tests with 'acctest.ConfigCompose' - apiga…

da07ea1

…tewayv2.

Replace '+ ' in acceptance tests with 'acctest.ConfigCompose' - batch.

e44a346

Replace '+ ' in acceptance tests with 'acctest.ConfigCompose' - cogni…

01ab01b

…toidentity.

Replace '+ ' in acceptance tests with 'acctest.ConfigCompose' - ec2.

db7bf6a

Replace '+ ' in acceptance tests with 'acctest.ConfigCompose' - elbv2.

6abd556

Replace '+ ' in acceptance tests with 'acctest.ConfigCompose' - events.

0f72bc4

Replace '+ ' in acceptance tests with 'acctest.ConfigCompose' - ssm.

644aa93

Replace '+ ' in acceptance tests with 'acctest.ConfigCompose' - stora…

eb05751

…gegateway.

Replace '+ ' in acceptance tests with 'acctest.ConfigCompose' - wafre…

077fc89

…gional.

ewbankkit approved these changes Aug 8, 2024

View reviewed changes

ewbankkit merged commit 0aba279 into hashicorp:main Aug 8, 2024
42 checks passed

github-actions bot added this to the v5.62.0 milestone Aug 8, 2024

github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 9, 2024

github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

directconnect: Migrate to AWS SDK v2 #37213

directconnect: Migrate to AWS SDK v2 #37213

mattburgess commented May 1, 2024 •

edited by jar-b

Loading

github-actions bot commented May 1, 2024

github-actions bot commented May 1, 2024

ewbankkit left a comment

ewbankkit commented Aug 8, 2024

github-actions bot commented Aug 9, 2024

github-actions bot commented Sep 9, 2024

directconnect: Migrate to AWS SDK v2 #37213

directconnect: Migrate to AWS SDK v2 #37213

Conversation

mattburgess commented May 1, 2024 • edited by jar-b Loading

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented May 1, 2024

Community Note

github-actions bot commented May 1, 2024

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Aug 8, 2024

github-actions bot commented Aug 9, 2024

github-actions bot commented Sep 9, 2024

mattburgess commented May 1, 2024 •

edited by jar-b

Loading