Add mongodb atlas for bedrock kb #37220
Draft
+95
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
the
size/M
terraform-aws-provider
bot
added
the
needs-triage
github-actions
bot
added
documentation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @tubone24 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
justinretzolk
added
enhancement
itsnicksia
reviewed
May 7, 2024
| "endpoint": schema.StringAttribute{ | ||
| Required: true, | ||
| }, | ||
| "vectorIndexName": schema.StringAttribute{ |
There was a problem hiding this comment.
This should be vector_index_name
"vectorIndexName" at schema path "storage_configuration.mongodb_atlas_configuration.vectorIndexName" is an invalid attribute/block name. Names must only contain lowercase alphanumeric characters (a-z, 0-9) and underscores (_).
itsnicksia
reviewed
May 7, 2024
| "vectorIndexName": schema.StringAttribute{ | ||
| Required: true, | ||
| }, | ||
| "endpointServiceName": schema.StringAttribute{ |
There was a problem hiding this comment.
This should be endpoint_service_name
"endpointServiceName" at schema path "storage_configuration.mongodb_atlas_configuration.endpointServiceName" is an invalid attribute/block name. Names must only contain lowercase alphanumeric characters (a-z, 0-9) and underscores (_)
itsnicksia
reviewed
May 7, 2024
| endpoint types.String `tfsdk:"endpoint"` | ||
| vectorIndexName types.String `tfsdk:"vector_index_name"` | ||
| endpointServiceName fwtypes.ARN `tfsdk:"endpoint_service_name"` | ||
| FieldMapping fwtypes.ListNestedObjectValueOf[pineconeFieldMappingModel] `tfsdk:"field_mapping"` |
There was a problem hiding this comment.
pineconeFieldMappingModel should be mongoDBAtlasFieldMappingModel
itsnicksia
reviewed
May 7, 2024
| @@ -642,6 +693,23 @@ type pineconeFieldMappingModel struct { | |||
| TextField types.String `tfsdk:"text_field"` | |||
| } | |||
|
|
|||
| type mongoDBAtlasConfigurationModel struct { | |||
| collectionName types.String `tfsdk:"connection_name"` | |||
There was a problem hiding this comment.
Attribute names need to be capitalized.
itsnicksia
reviewed
May 7, 2024
| type mongoDBAtlasFieldMappingModel struct { | ||
| MetadataField types.String `tfsdk:"metadata_field"` | ||
| TextField types.String `tfsdk:"text_field"` | ||
| vectorField types.String `tfsdk:"vector_field"` |
|
Thanks @tubone24! My first time commenting here; running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relations
Closes #37253.
References
Output from Acceptance Testing