-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_cloudformation_stack_set_instance: add support for additional deployment_targets config and refactor update deployment_targets config #37898
base: main
Are you sure you want to change the base?
Conversation
…eployment_targets parameter, it will be recreated.
…into f-cfn-stacksetinstance-update-deployment-targets
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @yhamano0312 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Community Note
Description
resource/aws_cloudformation_stack_set_instance: Extend
deployment_targets
argument. Adding new argument foraccount_filter_type
,accounts
, andaccounts_url
.ref: https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/cloudformation/types#DeploymentTargets
Additionally, fixing a bug that prevents updating the instance when the
deployment_targets
argument is updated. The original code executes theupdate-stack-instances
API when changes are made to thedeployment_targets
argument. However, this API does not support updates todeployment_targets
. Therefore, if there are updates todeployment_targets
, the resource will be recreated. In PR #24523, theForceNew
difference was added to thedeployment_targets
argument, but it was necessary to addForceNew
to the arguments included in the deployment_targets setting in order to recreate.Relations
Closes #27877
Closes #33785
Closes #25253
Closes #33914
Relates #26935
Relates #24523
References
Output from Acceptance Testing