[New Resource] aws_default_internet_gateway

[PeterSzegedi]

Description

New resource to enable deletion and creation of "default" IGWs.
The reason to have it is to fix issue 23488
Currently the aws_default_vpc resource does not work due to having an IGW attached by default.

The Internet Gateways have no isDefault property on AWS, so there is no way to identify them outside of "if it is attached to a default VPC, it is the default IGW". The logic attributes this in the resource

Relations

Closes #23488.
Relates #3999.

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @PeterSzegedi 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

@PeterSzegedi Thanks for the contribution 👏.
The maintainers have discussed this and would prefer to use a Terraform import block to manage the default VPC's IGW; for example:

data "aws_vpc" "default" {
  default = true
}

data "aws_internet_gateway" "default" {
  filter {
    name   = "attachment.vpc-id"
    values = [data.aws_vpc.default.id]
  }
}

import {
  to = aws_internet_gateway.default
  id = data.aws_internet_gateway.default.id
}

resource "aws_internet_gateway" "default" {
  vpc_id = data.aws_vpc.default.id
}

Does this fulfill your use case?