Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump max timeout for REST API Gateway to 5 mins #37905

Closed
wants to merge 1 commit into from

Conversation

chainchad
Copy link

@chainchad chainchad commented Jun 10, 2024

Description

AWS recently announced that the REST API Gateways had an increased timeout limit and this bumps that max timeout validation check from 29 seconds to 300 seconds.

edit: going to up to 5 mins would require a service quota increase per AWS account.

Relations

Closes #23417
Closes #37859

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/apigateway Issues and PRs that pertain to the apigateway service. labels Jun 10, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 10, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @chainchad 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. timeouts Pertains to timeout increases. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 11, 2024
@dhrkumar
Copy link
Contributor

@chainchad do we have any reference which documents maximum quota for integration timeout in REST API is 300 seconds now? I see the documentation refers that it might require a reduction in account-level throttle quota limit but doesn't mention any explicit maximum quota.

@chainchad
Copy link
Author

@dhrkumar I was given 300s as an example from AWS support but that might not be a true maximum. Going to try and confirm. If there's no enforced maximum (seems unlikely), I suppose we can just enforce the minimum timeout?

From AWS:

PLEASE NOTE - YOUR ACCOUNT LEVEL RPS WILL BE LOWERED ACCORDING TO THE FORMULA: 10,000 / [(IntegrationTimeoutLimit Seconds) / 29]

@chainchad
Copy link
Author

Just heard back from AWS support that 300s is the true maximum and I've asked if their docs can reflect that.

@ewbankkit
Copy link
Contributor

@chainchad Thanks for the contribution 🎉 👏.
This change has been included in #38010.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. size/XS Managed by automation to categorize the size of a PR. timeouts Pertains to timeout increases.
Projects
None yet
4 participants