Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

names_data.csv conversion to names_data.hcl #37960

Merged
merged 61 commits into from
Jun 17, 2024
Merged

names_data.csv conversion to names_data.hcl #37960

Changes from 1 commit
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
6e14360
Add files via upload
ThomasZalewski Jun 11, 2024
fb3b3fc
Update README.md
ThomasZalewski Jun 11, 2024
a2f1294
Update README.md
ThomasZalewski Jun 11, 2024
ab34cca
Update README.md
ThomasZalewski Jun 11, 2024
6b23bdc
Update README.md
ThomasZalewski Jun 11, 2024
8a219b8
Update README.md
ThomasZalewski Jun 12, 2024
cf4541c
Update README.md
ThomasZalewski Jun 12, 2024
6b0d619
Merge branch 'hashicorp:main' into main
ThomasZalewski Jun 12, 2024
a270122
Update add-a-new-service.md
ThomasZalewski Jun 12, 2024
d598d14
Update add-a-new-service.md
ThomasZalewski Jun 12, 2024
48eee7f
Update README.md
ThomasZalewski Jun 12, 2024
e06a687
Merge branch 'hashicorp:main' into main
ThomasZalewski Jun 12, 2024
694add7
Updated to pass make gen-check
ThomasZalewski Jun 12, 2024
eb24c10
Deleted several checks for compatibility with hcl
ThomasZalewski Jun 12, 2024
877c6d4
Merge branch 'hashicorp:main' into main
ThomasZalewski Jun 13, 2024
c4890ce
Merge branch 'hashicorp:main' into main
ThomasZalewski Jun 13, 2024
9b433a7
Formatting updates
ThomasZalewski Jun 13, 2024
4c38c07
Reverted the deletion of a test
ThomasZalewski Jun 13, 2024
0298c5c
Merge branch 'hashicorp:main' into main
ThomasZalewski Jun 13, 2024
11e9e87
Updated names_data.hcl to support sdkv2 migration
ThomasZalewski Jun 13, 2024
93bef81
Added provider_package_correct to README.md
ThomasZalewski Jun 13, 2024
8f9bd19
Merge branch 'hashicorp:main' into main
ThomasZalewski Jun 13, 2024
eddb60f
Merge branch 'hashicorp:main' into main
ThomasZalewski Jun 13, 2024
b959f9d
Merge branch 'hashicorp:main' into main
ThomasZalewski Jun 13, 2024
29dd494
Embedded names_data.hcl
ThomasZalewski Jun 13, 2024
a27304d
Update docs/add-a-new-service.md
ThomasZalewski Jun 13, 2024
8389b5a
Update docs/add-a-new-service.md
ThomasZalewski Jun 13, 2024
3925a3e
Update names/README.md
ThomasZalewski Jun 13, 2024
4894acf
Update names/README.md
ThomasZalewski Jun 13, 2024
6d5ea21
Update README.md
ThomasZalewski Jun 13, 2024
f468c40
Update docs/add-a-new-service.md
ThomasZalewski Jun 13, 2024
eeb372a
Update docs/add-a-new-service.md
ThomasZalewski Jun 13, 2024
b27004c
Update docs/add-a-new-service.md
ThomasZalewski Jun 13, 2024
680614c
Added copywrite header to names_data.hcl
ThomasZalewski Jun 13, 2024
a0f149f
Fixed consecutive blank lines issue
ThomasZalewski Jun 13, 2024
a8ca956
Fixed csv/hcl typo
ThomasZalewski Jun 14, 2024
f33606b
Fixed csv/hcl typo
ThomasZalewski Jun 14, 2024
1c71c18
Merge branch 'hashicorp:main' into main
ThomasZalewski Jun 14, 2024
e7e4895
Updated applicationinsights to sdkv2
ThomasZalewski Jun 14, 2024
6e6087e
Merge branch 'hashicorp:main' into main
ThomasZalewski Jun 14, 2024
5ae3e38
Fixed up go.mod and go.sum for skaff
ThomasZalewski Jun 14, 2024
b979cfb
Revert "Fixed up go.mod and go.sum for skaff"
ThomasZalewski Jun 14, 2024
fc90aa3
Added hclparse package to go.mo
ThomasZalewski Jun 14, 2024
cb28f45
Go mod tidy changes
ThomasZalewski Jun 14, 2024
8766396
results of make clean-tidy
ThomasZalewski Jun 14, 2024
96d344d
Merge branch 'hashicorp:main' into main
ThomasZalewski Jun 14, 2024
85bb4ca
Delete names/data/names_data.csv
ThomasZalewski Jun 14, 2024
33a7499
Update README.md to support schema changes
ThomasZalewski Jun 14, 2024
4878937
Update add-a-new-service.md to support optional attributes
ThomasZalewski Jun 14, 2024
089cc0d
Merge branch 'hashicorp:main' into main
ThomasZalewski Jun 14, 2024
ddf1f2a
Update go_v1_client_typename in README.md
ThomasZalewski Jun 14, 2024
786ee4c
Reformatted hcl file and updated read.go to support reformatting. New…
ThomasZalewski Jun 14, 2024
bef7a85
Merge branch 'main' of github.com:ThomasZalewski/terraform-provider-aws
ThomasZalewski Jun 14, 2024
743e113
Update README.md
ThomasZalewski Jun 14, 2024
afdc92e
Linter changes
ThomasZalewski Jun 17, 2024
ddc6ef7
Fixed HCL schema issues with Cloud Control, CodeDeploy, and Transcribe.
ThomasZalewski Jun 17, 2024
afa9f79
Merge branch 'main' into ThomasZalewski_go.sum_merge
ThomasZalewski Jun 17, 2024
a4d51ad
Skaff changes
ThomasZalewski Jun 17, 2024
6d31b7a
Fixed hcl issue with code deploy
ThomasZalewski Jun 17, 2024
8d00b5a
Added copyright marker for names_data.hcl
ThomasZalewski Jun 17, 2024
53a384f
Updated README.md to allow the omitting of aliases
ThomasZalewski Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update docs/add-a-new-service.md 
Fixed code formatting

Co-authored-by: Simon Davis <simon@breathingdust.com>
  • Loading branch information
@ThomasZalewski @breathingdust
ThomasZalewski and breathingdust committed Jun 13, 2024
commit eeb372af25d3c23b7b930e97852a628ae7c9fe80
2 changes: 1 addition & 1 deletion docs/add-a-new-service.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ Once the service client has been added, implement the first [resource](./add-a-n

If an AWS service must be created in a non-standard way, for example, the service API's endpoint must be accessed via a single AWS Region, then:

1. Make the `SkipClientGenerate` attribute `true` for the service in [`names/data/names_data.hcl`](https://github.com/hashicorp/terraform-provider-aws/blob/main/names/README.md)
1. Make the `skip_client_generate` attribute `true` for the service in [`names/data/names_data.hcl`](https://github.com/hashicorp/terraform-provider-aws/blob/main/names/README.md)

1. Run `make gen`

Expand Down
Loading