Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add fields to attribute reference of route53 zone data #37994

Conversation

stefanfreitag
Copy link

Description

  • Add missing fields name, private_zone, tags, zone_id
  • Re-ordered attributes alphabetically

Additional cleanup:

  • Removed blank link from Argument Reference section
  • Add missing . to a sentence in Argument Reference section

Relations

Closes #37908 .
In the title of the related issue "missing id" is mentioned. In the description and code example zone_id is mentioned, e.g.

output "zone_id" {
  value = data.aws_route53_zone.id
}

I opted for adding zone_id, and leaving id out.
Please let me know if I should add id also. Contentwise id and zone_id are identical.

References

None.

Output from Acceptance Testing

  • Not applicable. Only documentation was updated.

- Add missing fields `name`, `private_zone`, `tags`, `zone_id`
- Re-ordered attributes alphabetically

Additional cleanup:
- Removed blank link from Argument Reference section
- Add missing `.` to a sentence in Argument Reference section
@stefanfreitag stefanfreitag requested a review from a team as a code owner June 15, 2024 13:32
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/route53 Issues and PRs that pertain to the route53 service. labels Jun 15, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 15, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jun 21, 2024
@ewbankkit
Copy link
Contributor

@stefanfreitag Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ccfd07d into hashicorp:main Jun 21, 2024
50 checks passed
@github-actions github-actions bot added this to the v5.56.0 milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/route53 Issues and PRs that pertain to the route53 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: data source aws_route53_zone missing id and name attribute
3 participants