Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix improper use of "argument" as ref to resources, data sources, and config blocks #38147

Merged
merged 1 commit into from
Jun 27, 2024
Merged

docs: Fix improper use of "argument" as ref to resources, data sources, and config blocks #38147

merged 1 commit into from
Jun 27, 2024

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Jun 27, 2024

Description

This PR is to fix the improper use of the word "argument" to refer to resources, data sources, and configuration blocks in the first sentence of various resource and data source documentation.

Relations

Closes #38072

References

n/a

Output from Acceptance Testing

n/a

@acwwat acwwat requested a review from a team as a code owner June 27, 2024 04:13
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/guardduty Issues and PRs that pertain to the guardduty service. service/configservice Issues and PRs that pertain to the configservice service. service/rds Issues and PRs that pertain to the rds service. service/directconnect Issues and PRs that pertain to the directconnect service. service/lightsail Issues and PRs that pertain to the lightsail service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/storagegateway Issues and PRs that pertain to the storagegateway service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/appsync Issues and PRs that pertain to the appsync service. service/glue Issues and PRs that pertain to the glue service. service/route53domains Issues and PRs that pertain to the route53domains service. service/connect Issues and PRs that pertain to the connect service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/docdb Issues and PRs that pertain to the docdb service. service/sesv2 Issues and PRs that pertain to the sesv2 service. service/elastictranscoder Issues and PRs that pertain to the elastictranscoder service. service/vpc Issues and PRs that pertain to the vpc service. labels Jun 27, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Jun 27, 2024
justinretzolk
justinretzolk approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@justinretzolk justinretzolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you very much for taking the time to take care of this! I'll get it merged as soon as the checks go ✅

@justinretzolk justinretzolk merged commit 01b084c into hashicorp:main Jun 27, 2024
59 of 60 checks passed
@github-actions github-actions bot added this to the v5.56.0 milestone Jun 27, 2024
@terraform-aws-provider terraform-aws-provider bot removed the needs-triage Waiting for first response or review from a maintainer. label Jun 27, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinretzolk justinretzolk justinretzolk approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appsync Issues and PRs that pertain to the appsync service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/configservice Issues and PRs that pertain to the configservice service. service/connect Issues and PRs that pertain to the connect service. service/directconnect Issues and PRs that pertain to the directconnect service. service/docdb Issues and PRs that pertain to the docdb service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/elastictranscoder Issues and PRs that pertain to the elastictranscoder service. service/glue Issues and PRs that pertain to the glue service. service/guardduty Issues and PRs that pertain to the guardduty service. service/lightsail Issues and PRs that pertain to the lightsail service. service/rds Issues and PRs that pertain to the rds service. service/route53domains Issues and PRs that pertain to the route53domains service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. service/sesv2 Issues and PRs that pertain to the sesv2 service. service/storagegateway Issues and PRs that pertain to the storagegateway service. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v5.56.0
Development

Successfully merging this pull request may close these issues.

[Docs]: "This argument supports the following arguments"
2 participants
@acwwat @justinretzolk