Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce labelers workflow #1742

Merged
merged 5 commits into from
Jun 6, 2024
Merged

Conversation

justinretzolk
Copy link
Member

@justinretzolk justinretzolk commented May 23, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
  • The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.

About

This pull request introduces a new labeler workflow that has similar functionality to what we use in terraform-provider-aws, but has been rewritten quite a bit to try to make it more readable and clean. Since it covered the functionality of two existing workflows, those have been removed. The new workflow will:

  • Add prioritized to:
    • issues and pull requests assigned to maintainers
    • pull requests created by maintainers
  • Add needs-triage to new issues and pull requests not created by a maintainer
  • Add partner to pull requests from partners
  • Add external-maintainer to pull requests from Core Contributors
  • Remove stale and waiting-response when non-maintainers edit or comment on issues or pull requests
  • Remove needs-triage and waiting-response when issues or pull requests are closed

Depends on #1743

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@justinretzolk
Copy link
Member Author

Revised a bit to eliminate the separate job for community checks -- reduces the number of jobs that show up in PR status checks.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@justinretzolk justinretzolk merged commit 15b621f into main Jun 6, 2024
2 checks passed
@justinretzolk justinretzolk deleted the introduce-labelers-workflow branch June 6, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants