Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add namespace to sa error message #2539

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

tomkukral
Copy link
Contributor

ServiceAccount name may not be unique across namespaces, so it may be hard to understand which ServiceAccount is being referred.

ServiceAccount name may not be unique across namespaces, so it may be
hard to understand which ServiceAccount is being referred.
@tomkukral tomkukral requested a review from a team as a code owner July 3, 2024 08:03
Copy link

hashicorp-cla-app bot commented Jul 3, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, @tomkukral, thank you!

@arybolovlev arybolovlev merged commit ca45276 into hashicorp:main Jul 3, 2024
17 of 19 checks passed
@tomkukral
Copy link
Contributor Author

Thank you for very fast merging 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants