Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update Terraform SDK and Nomad #345

Merged
merged 4 commits into from
Jul 12, 2023
Merged

deps: update Terraform SDK and Nomad #345

merged 4 commits into from
Jul 12, 2023

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Jul 12, 2023

I'm not sure how but I ended up picking an old version of the SDK in #339 😅

Also update the Nomad dependency to RC to pin the HCLv2 dependency to the same as Nomad, otherwise there's an import conflict with the SDK.

go install
# github.com/hashicorp/nomad/jobspec2
../../../../pkg/mod/github.com/hashicorp/nomad@v1.5.2/jobspec2/hcl_conversions.go:18:23: undefined: gohcl.Decoder
../../../../pkg/mod/github.com/hashicorp/nomad@v1.5.2/jobspec2/hcl_conversions.go:26:29: undefined: gohcl.Decoder
../../../../pkg/mod/github.com/hashicorp/nomad@v1.5.2/jobspec2/hcl_conversions.go:27:20: undefined: gohcl.Decoder
../../../../pkg/mod/github.com/hashicorp/nomad@v1.5.2/jobspec2/types.config.go:311:3: unknown field UndefinedVariable in struct literal of type hcl.EvalContext

The new SDK also picked some existing errors that were previously ignored in v1, so I'm fixing them here as well.

@lgfa29 lgfa29 requested review from shoenig and jrasell July 12, 2023 21:08
@lgfa29 lgfa29 changed the title Update tf sdk and nomad deps: update Terraform SDK and Nomad Jul 12, 2023
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lgfa29 lgfa29 merged commit 92d7b40 into main Jul 12, 2023
1 check passed
@lgfa29 lgfa29 deleted the update-tf-sdk-and-nomad branch July 12, 2023 21:31
@lgfa29 lgfa29 added this to the 2.0.0 milestone Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants