Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/job: set namespace on monitor #347

Merged
merged 3 commits into from
Jul 13, 2023
Merged

resource/job: set namespace on monitor #347

merged 3 commits into from
Jul 13, 2023

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Jul 12, 2023

When monitoring the job deployment and allocations the provider needs to set the job namespace in the request instead of relying on the provider configuration as it may be different from the job.

Closes #300

@lgfa29
resource/job: set namespace on monitor
dd2b3f8 
When monitoring the job deployment and allocations the provider needs to
set the job namespace in the request instead of relying on the provider
configuration as it may be different from the job.
@lgfa29
changelog: add entry for #347
17559cb
@lgfa29 lgfa29 requested review from jrasell and gulducat July 12, 2023 22:22
@lgfa29 lgfa29 mentioned this pull request Jul 12, 2023
Closed
jrasell
jrasell approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I wonder if we want to add the namespace to any of the debug logs? Not required in this PR, but could be a followup if we think it's worth it.

@lgfa29
Copy link
Contributor Author

lgfa29 commented Jul 13, 2023

I wonder if we want to add the namespace to any of the debug logs?

Added 👍

@lgfa29 lgfa29 merged commit 4a5360e into main Jul 13, 2023
1 check failed
@lgfa29 lgfa29 deleted the b-set-namespace-on-job-monitor branch July 13, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasell jrasell jrasell approved these changes

@gulducat gulducat Awaiting requested review from gulducat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing "namespace" in HTTP request in nomad_job with "detach=false" for ACL enabled Nomad
2 participants
@lgfa29 @jrasell