Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volume: fix nil retryable error #354

Merged
merged 2 commits into from
Jul 26, 2023
Merged

volume: fix nil retryable error #354

merged 2 commits into from
Jul 26, 2023

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Jul 25, 2023

Prevent errors of kind Error: empty retryable error received.

Sample error: https://github.com/hashicorp/terraform-provider-nomad/actions/runs/5600076107/job/15169538864#step:8:118

No changelog since this change has not been released.

Prevent errors of kind `Error: empty retryable error received.`
@lgfa29 lgfa29 requested review from jrasell and gulducat July 25, 2023 20:54
@lgfa29
Copy link
Contributor Author

lgfa29 commented Jul 25, 2023

Also drive-by fix on TestDataSourceNodePool 😅
https://github.com/hashicorp/terraform-provider-nomad/actions/runs/5661659566/job/15340028038#step:8:57

Remaining test failures are known flakes that I will fix in follow-up PR.

@lgfa29 lgfa29 merged commit 0189123 into main Jul 26, 2023
1 of 2 checks passed
@lgfa29 lgfa29 deleted the b-fix-volume-tests branch July 26, 2023 14:27
@f3l1x
Copy link

f3l1x commented Jul 27, 2023

Looking forward to next version, if you release RC I will test it ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants