Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/job: use semantic jobspec diff #356

Merged
merged 2 commits into from
Jul 26, 2023
Merged

resource/job: use semantic jobspec diff #356

merged 2 commits into from
Jul 26, 2023

Commits on Jul 26, 2023

  1. resource/job: use semantic jobspec diff 

    The previous implementation of the custom jobspec diff used a naive
string equality check, which can result in unnecessary plan diffs due to
inconsequential changes, like comments or spaces being added/removed.

By reusing the same logic as the `jobspec` field diff we compare the job
struct as it would be submitted to the Nomad API.
    @lgfa29
    lgfa29 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    665c2f9 View commit details
    Browse the repository at this point in the history

  2. changelog: add entry for #356

    @lgfa29
    lgfa29 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    1237149 View commit details
    Browse the repository at this point in the history