chore: update vault test matrix #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairclothjm
changed the title
|
Reverting the Vault SDK bump for now since it looks like we need to update TFVP. I think the failures are related to hashicorp/vault#25744 |
fairclothjm
force-pushed
the
update-build
branch
from
2f7a185
to
662ee2c
Compare
fairclothjm
changed the title
|
Also reverting the go version bump. It seems to be breaking our tests? |
|
Looks like the Secrets Sync Config test is failing due to the feature flag not being enabled. We should probably skip that test in CI since it can only be run on servers where the feature has been enabled (whoops!). We can add a skip on this line either in this PR or a follow up PR: |
|
@vinay-gopalan Thanks! Done in 48a48c9 |
vinay-gopalan
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.