Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add validation for category_id in r/vsphere_tag #2261

Conversation

burnsjared0415
Copy link
Collaborator

@burnsjared0415 burnsjared0415 commented Sep 16, 2024

Description

Added validation to vsphere_tag to ensure category_id is a valid format.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

Running tool: /usr/local/bin/go test -timeout 30s -run ^TestAccResourceVSphereTag_basic$ github.com/hashicorp/terraform-provider-vsphere/vsphere

ok  	github.com/hashicorp/terraform-provider-vsphere/vsphere	(cached)

Release Note

resource\vsphere_tag: Adds a format validation for catagory_id.

References

Closes #1680

@burnsjared0415 burnsjared0415 self-assigned this Sep 16, 2024
@github-actions github-actions bot added documentation Type: Documentation provider Type: Provider needs-review Status: Pull Request Needs Review labels Sep 16, 2024
@burnsjared0415 burnsjared0415 force-pushed the feat/add_validation_of_catagory_id_tags branch from 22d05ae to 38a4d3c Compare September 16, 2024 13:39
@tenthirtyam tenthirtyam self-requested a review September 16, 2024 16:27
@tenthirtyam tenthirtyam added this to the v2.9.2 milestone Sep 16, 2024
@burnsjared0415 burnsjared0415 force-pushed the feat/add_validation_of_catagory_id_tags branch from 38a4d3c to 159a5f7 Compare September 16, 2024 16:37
@tenthirtyam tenthirtyam marked this pull request as ready for review September 16, 2024 16:49
@tenthirtyam tenthirtyam requested a review from a team as a code owner September 16, 2024 16:49
@tenthirtyam tenthirtyam added area/tagging Area: Tagging and removed documentation Type: Documentation labels Sep 16, 2024
@github-actions github-actions bot added the documentation Type: Documentation label Sep 16, 2024
@tenthirtyam tenthirtyam force-pushed the feat/add_validation_of_catagory_id_tags branch from 159a5f7 to 81fa779 Compare September 16, 2024 16:58
@tenthirtyam tenthirtyam removed the documentation Type: Documentation label Sep 16, 2024
@github-actions github-actions bot added the documentation Type: Documentation label Sep 16, 2024
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Reviewed live with Jared to also review the outcome.

@tenthirtyam tenthirtyam changed the title feat: r/vsphere_tag added validation to category_id feat: add validation for category_id in r/vsphere_tag Sep 16, 2024
@tenthirtyam tenthirtyam removed the documentation Type: Documentation label Sep 16, 2024
@github-actions github-actions bot added the documentation Type: Documentation label Sep 16, 2024
Added validation to `vsphere_tag` to ensure `category_id` is a valid format.

Ref: hashicorp#1680

Signed-off-by: Jared Burns <jared.burns@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the feat/add_validation_of_catagory_id_tags branch from 81fa779 to 702dda9 Compare September 16, 2024 18:25
@tenthirtyam tenthirtyam removed documentation Type: Documentation needs-review Status: Pull Request Needs Review labels Sep 16, 2024
@tenthirtyam tenthirtyam merged commit 23dcfba into hashicorp:main Sep 16, 2024
4 checks passed
Copy link

This functionality has been released in v2.9.2 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/tagging Area: Tagging provider Type: Provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for r/vsphere_tag to validate the category_id attribute content
3 participants