Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for vtpm #2279

Merged

Conversation

burnsjared0415
Copy link
Collaborator

@burnsjared0415 burnsjared0415 commented Oct 8, 2024

Description

Added Support for vTPM on creation and clone of virtual machine.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

Running tool: /usr/local/bin/go test -timeout 30s -run ^TestAccResourceVSphereVirtualMachine_basic$ github.com/hashicorp/terraform-provider-vsphere/vsphere

ok  	github.com/hashicorp/terraform-provider-vsphere/vsphere	1.076s
Running tool: /usr/local/bin/go test -timeout 30s -run ^TestAccResourceVSphereVirtualMachine_hardwareVersionBare$ github.com/hashicorp/terraform-provider-vsphere/vsphere

ok  	github.com/hashicorp/terraform-provider-vsphere/vsphere	0.981s
Running tool: /usr/local/bin/go test -timeout 30s -run ^TestAccResourceVSphereVirtualMachine_addDevices$ github.com/hashicorp/terraform-provider-vsphere/vsphere

ok  	github.com/hashicorp/terraform-provider-vsphere/vsphere	0.983s
$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Closes #1599

@burnsjared0415 burnsjared0415 added the breaking-change Status: Breaking Change label Oct 8, 2024
@burnsjared0415 burnsjared0415 added this to the v2.9.3 milestone Oct 8, 2024
@burnsjared0415 burnsjared0415 self-assigned this Oct 8, 2024
@github-actions github-actions bot added documentation Type: Documentation provider Type: Provider needs-review Status: Pull Request Needs Review labels Oct 8, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some initial small changes - will wait for your update and the CI to pass. :)

@tenthirtyam tenthirtyam changed the title feat: r/vsphere_virtual_machine add support for vTPM feat: add support for vtpm Oct 8, 2024
@tenthirtyam tenthirtyam modified the milestones: v2.9.3, On Deck Oct 8, 2024
@burnsjared0415 burnsjared0415 force-pushed the feat/add_support_for_vtpm branch 2 times, most recently from 7cb1360 to d28111d Compare October 8, 2024 16:44
@tenthirtyam tenthirtyam modified the milestones: On Deck, v2.10.0 Oct 8, 2024
@tenthirtyam tenthirtyam removed the breaking-change Status: Breaking Change label Oct 8, 2024
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional suggested changes to review for checking the status of the firmware and the removal of a function that isn't used at this time.

@tenthirtyam tenthirtyam marked this pull request as ready for review October 8, 2024 21:56
@tenthirtyam tenthirtyam requested a review from a team as a code owner October 8, 2024 21:56
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and our offline demo was great.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits.

@burnsjared0415 burnsjared0415 added the enhancement Type: Enhancement label Oct 10, 2024
@tenthirtyam tenthirtyam force-pushed the feat/add_support_for_vtpm branch 3 times, most recently from 1e40ed8 to cd21396 Compare October 11, 2024 17:48
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@tenthirtyam tenthirtyam removed the needs-review Status: Pull Request Needs Review label Oct 11, 2024
Added support for virtual Trusted Platform Module (`vtpm`) on creation and clone of virtual machine.

Signed-off-by: Jared Burns <jared.burns@broadcom.com>
@github-actions github-actions bot added the needs-review Status: Pull Request Needs Review label Oct 16, 2024
@tenthirtyam tenthirtyam merged commit 952f6cb into hashicorp:main Oct 16, 2024
4 checks passed
Copy link

This functionality has been released in v2.10.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Type: Documentation enhancement Type: Enhancement needs-review Status: Pull Request Needs Review provider Type: Provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for vTPM
3 participants