feat: add usb controller

[burnsjared0415]

Description

Add the ability to add usb controller on build and modification of virtual machine.

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Output from acceptance testing:

Running tool: /usr/local/bin/go test -timeout 30s -run ^TestAccResourceVSphereVirtualMachine_basic$ github.com/hashicorp/terraform-provider-vsphere/vsphere

ok  	github.com/hashicorp/terraform-provider-vsphere/vsphere	0.885s

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Closes #620

[tenthirtyam]

Based on the vSphere configuration maximums for v7 and v8m USB 1.x, 2.x, and 3.x is supported; however, only one USB host controller of each version 1.x, 2.x, or 3.x can be added at the same time.

[tenthirtyam]

Maybe something like

var usbControllerVersions = []string{"2.0", "3.1"}

But account for the 1.x (more than one 1.x version?)

And then:

ValidateFunc: validation.StringInSlice(usbControllerVersions, false),

[tenthirtyam]

Maybe:

			},
		},
		ValidateFunc: validateUSBControllerVersions,

And add a function to ensure only one of each can be added. FOr example

func validateUSBControllerVersions(val interface{}, key string) (warns []string, errs []error) {
    usbControllers := val.([]interface{})
    versionCount := make(map[string]int)
    for _, version := range usbControllerVersions {
        versionCount[version] = 0
    }

    for _, controller := range usbControllers {
        controllerMap := controller.(map[string]interface{})
        version := controllerMap["usb_version"].(string)
        if _, exists := versionCount[version]; exists {
            versionCount[version]++
            if versionCount[version] > 1 {
                errs = append(errs, fmt.Errorf("%q cannot have more than one USB controller of version %s", key, version))
            }
        }
    }
    return
}

[tenthirtyam]

Maybe something that would return more like this since more than one controller can be present but only one per version.

[
    {
        "usb_controller": true,
        "usb_version": "2.0"
    },
    {
        "usb_controller": false,
        "usb_version": "3.1"
    }
]

[tenthirtyam]

Maybe something like this?

usbPresence := make(map[string]bool)
for _, version := range usbControllerVersions {
    usbPresence[version] = false
}

for _, dev := range vprops.Config.Hardware.Device {
    switch dev.(type) {
    case *types.VirtualUSBController:
        usbPresence["2.0"] = true
    case *types.VirtualUSBXHCIController:
        usbPresence["3.1"] = true
    }
}

var usbControllers []map[string]interface{}
for version, present := range usbPresence {
    usbControllers = append(usbControllers, map[string]interface{}{
        "usb_controller": present,
        "usb_version":    version,
    })
}

_ = d.Set("usb_controller", usbControllers)

[burnsjared0415]

if i can get a lab up i can test this, just not sure i want to chage it until i can test

[tenthirtyam]

Left some thoughts on supporting only a single USB controller for each supported version based on the configuration maximums in v7 and v8.