feat: d/vsphere_network add support for network_type #2281
Merged
+131
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
burnsjared0415
force-pushed
the
feat/d/vsphere_netowrk-add-supprot-for-port-group-type
branch
from
2c01073
to
6046f0b
Compare
tenthirtyam
requested changes
Oct 10, 2024
burnsjared0415
force-pushed
the
feat/d/vsphere_netowrk-add-supprot-for-port-group-type
branch
from
6046f0b
to
1616769
Compare
tenthirtyam
reviewed
Oct 10, 2024
tenthirtyam
reviewed
Oct 10, 2024
burnsjared0415
force-pushed
the
feat/d/vsphere_netowrk-add-supprot-for-port-group-type
branch
2 times, most recently
from
cfd7226
to
65de73e
Compare
tenthirtyam
reviewed
Oct 10, 2024
tenthirtyam
reviewed
Oct 10, 2024
tenthirtyam
reviewed
Oct 10, 2024
tenthirtyam
reviewed
Oct 10, 2024
tenthirtyam
reviewed
Oct 10, 2024
tenthirtyam
reviewed
Oct 10, 2024
tenthirtyam
reviewed
Oct 10, 2024
tenthirtyam
reviewed
Oct 10, 2024
tenthirtyam
reviewed
Oct 10, 2024
tenthirtyam
reviewed
Oct 10, 2024
tenthirtyam
reviewed
Oct 10, 2024
tenthirtyam
requested changes
Oct 10, 2024
burnsjared0415
force-pushed
the
feat/d/vsphere_netowrk-add-supprot-for-port-group-type
branch
from
65de73e
to
011f923
Compare
Added the feature to allow for port group to be found if there are two port groups with the same name but one is standard virtual port group vs distributed virtual port group. Signed-off-by: Jared Burns <jared.burns@broadcom.com>
burnsjared0415
force-pushed
the
feat/d/vsphere_netowrk-add-supprot-for-port-group-type
branch
from
011f923
to
539d271
Compare
iBrandyJackson
approved these changes
Oct 16, 2024
|
This functionality has been released in v2.10.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the feature to allow for port group to be found if there are two port groups with the same name but one is standard virtual port group vs distributed virtual port group.
Acceptance tests
Output from acceptance testing:
ok github.com/hashicorp/terraform-provider-vsphere/vsphere 0.847s
Release Note
Release note for CHANGELOG:
References
Closes #1143
Closes #1410