INTMDB217 - Wait until user is applied to clusters #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
thetonymaster
changed the title
gssbzn
reviewed
Aug 4, 2021
mongodbatlas.go
Outdated
| @@ -126,6 +128,56 @@ func (m *MongoDBAtlas) NewUser(ctx context.Context, req dbplugin.NewUserRequest) | |||
| return dbplugin.NewUserResponse{}, err | |||
| } | |||
|
|
|||
| clusters, _, err := client.Clusters.List(ctx, m.ProjectID, &mongodbatlas.ListOptions{}) | |||
| if err != nil { | |||
| return dbplugin.NewUserResponse{}, fmt.Errorf("roles array is required in creation statement") | |||
There was a problem hiding this comment.
[nit] no need for formatting
Suggested change
| return dbplugin.NewUserResponse{}, fmt.Errorf("roles array is required in creation statement") | |
| return dbplugin.NewUserResponse{}, errors.New("roles array is required in creation statement") |
mongodbatlas.go
Outdated
|
|
||
| operation := func() error { | ||
|
|
||
| status, _, err := client.Clusters.Status(context.Background(), m.ProjectID, clustername) |
There was a problem hiding this comment.
any reason not to reuse the context from outside the loop?
There was a problem hiding this comment.
Nope, will fix this
| @@ -126,6 +128,56 @@ func (m *MongoDBAtlas) NewUser(ctx context.Context, req dbplugin.NewUserRequest) | |||
| return dbplugin.NewUserResponse{}, err | |||
| } | |||
|
|
|||
| clusters, _, err := client.Clusters.List(ctx, m.ProjectID, &mongodbatlas.ListOptions{}) | |||
There was a problem hiding this comment.
this api call is paginated, if someone has more than 100 clusters you may miss those outside the [1,100] range
There was a problem hiding this comment.
It seems this is not correctly implemented on the client, will raise an issue with the mongo team
|
After some more research we have elected to not merge this PR. Please see #10 (comment) for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As reported in the Vault repo issue: #10
Right now the vault database user plugin for Atlas returns as soon as the API request is successfully accepted by Atlas. However the user takes time to apply to all the clusters in a project, meaning that if the credential is handed to an application that tries to then use that new credential right away- authentication fails. We now have an endpoint to check the status: https://docs.atlas.mongodb.com/reference/api/clusters-check-operation-status/
We need to build in the ability to poll that endpoint and wait to return the credential till it is really applied. Ideally this is an optional function so that if users would rather a faster return over being sure the user is really created we don't inadvertently frustrate them - if not possible then we'll default to the "really applied" default.
https://jira.mongodb.org/browse/INTMDB-217
Design of Change
Create a goroutine for each of the clusters then wait until the change is applied on each of them. Wrap the errors and return error or the user if it's sucessfull.
Related Issues/Pull Requests
https://jira.mongodb.org/browse/INTMDB-217
Contributor Checklist
[ ] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
My Docs PR Link
Example
[x] Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
[x] Backwards compatible
No documentation is necessary at the time