Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Allow metrics view without config read #12348

Merged
merged 3 commits into from
Aug 18, 2021

Conversation

hashishaw
Copy link
Contributor

Fixes a bug where if config is not read, the metrics do not render correctly due to badly assigned default value. Now, the parent component passes in a valid value even if the one read from config is not available. Notice in the screenshot, the config tab is still not visible if the user cannot read the config endpoint

Screen Shot 2021-08-18 at 12 33 41 PM

@hashishaw hashishaw added ui backport bug Used to indicate a potential bug labels Aug 18, 2021
@hashishaw hashishaw added this to the 1.6.6 milestone Aug 18, 2021
@vercel vercel bot temporarily deployed to Preview – vault August 18, 2021 17:35 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook August 18, 2021 17:37 Inactive

import authPage from 'vault/tests/pages/auth';
import logout from 'vault/tests/pages/logout';
import consoleClass from 'vault/tests/pages/components/console/ui-panel';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding test coverage

@hashishaw hashishaw merged commit fc1cf76 into main Aug 18, 2021
@hashishaw hashishaw deleted the ui/allow-no-config-read-metrics branch August 18, 2021 20:33
hashishaw added a commit that referenced this pull request Aug 19, 2021
* pass default value for defaultSpan on pricing metrics dates component

* Add changelog

* Add test for no config policy
hashishaw added a commit that referenced this pull request Aug 19, 2021
* pass default value for defaultSpan on pricing metrics dates component

* Add changelog

* Add test for no config policy
hashishaw added a commit that referenced this pull request Aug 19, 2021
* pass default value for defaultSpan on pricing metrics dates component

* Add changelog

* Add test for no config policy
hashishaw added a commit that referenced this pull request Aug 19, 2021
* pass default value for defaultSpan on pricing metrics dates component

* Add changelog

* Add test for no config policy
hashishaw added a commit that referenced this pull request Aug 19, 2021
* pass default value for defaultSpan on pricing metrics dates component

* Add changelog

* Add test for no config policy
hashishaw added a commit that referenced this pull request Aug 20, 2021
* pass default value for defaultSpan on pricing metrics dates component

* Add changelog

* Add test for no config policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants