Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-24581: Generalize activity log tests to run for all client types #26071

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

miagilepner
Copy link
Contributor

The actual changes for this ticket got completed as part of #26020, so this PR just generalizes the some tests so that they run for all client types, instead of just secret sync.

@miagilepner miagilepner added this to the 1.17.0 milestone Mar 21, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 21, 2024
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@raskchanky raskchanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent improvement!

@miagilepner miagilepner merged commit f2cd7e2 into main Mar 22, 2024
88 checks passed
@miagilepner miagilepner deleted the miagilepner/VAULT-24581-acme-responses branch March 22, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants