-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExternalID support to AWS Auth STS configuration #26628
Conversation
CI Results: |
Build Results: |
There probably should be a milestone, but the internal JIRA issue doesn't have one (yet?) |
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
stsReq.Data = data | ||
// create another entry to test the list operation | ||
stsReq.Data = data2 | ||
// create another entry with alternate data to test ExternalID and LIST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, could we add a block for checking "external_id": "fake_id"
existence in a read response before line 1455?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a response check for data2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs update lgtm
@kpcraig I'm assuming the update is meant for 1.17, but if it's not, don't forget to add the relevant backport labels for 1.16, 1.15, and/or 1.14 so the update publishes to the correct docset :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds support for ExternalIDs to be included in assume-role requests.