Backport of UI: Fix namespace picker in small screens into release/1.17.x #27731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/VAULT-28285/mobile-namespace-picker/eminently-epic-koala
branch
from
e69a1bf
to
561c706
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
hashishaw
approved these changes
Jul 9, 2024
|
Build Results: |
|
CI Results: |
hashishaw
deleted the
backport/ui/VAULT-28285/mobile-namespace-picker/eminently-epic-koala
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #27728 to be assessed for backporting due to the inclusion of the label backport/1.17.x.
The below text is copied from the body of the original PR.
Description
In small screens where the navbar gets collapsed by default, the namespace picker was broken in that nothing would happen when you open the sidebar, click the dropdown, and try to navigate to one of the namespace options. With this PR, the namespace picker dropdown is fully functional even in screens where the side nav is collapsed by default.
renderInPlaceis what fixed the behavior, but some CSS changes were necessary to make sure visually it looks the same as before:Overview of commits