Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Auto-rolling billing start docs PR into release/1.16.x #27998

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

akshya96
Copy link
Contributor

@akshya96 akshya96 commented Aug 6, 2024

  • auto-roll docs changes

  • addressing comments

  • address comments

  • Update website/content/api-docs/system/internal-counters.mdx

  • addressing some changes

  • update docs

  • update docs with common explanation file

  • updated note info

  • fix 1.18 upgrade doc

  • fix content-check error

  • Update website/content/partials/auto-roll-billing-start-example.mdx


Description

What does this PR do?

TODO only if you're a HashiCorp employee

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

* auto-roll docs changes

* addressing comments

* address comments

* Update website/content/api-docs/system/internal-counters.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* addressing some changes

* update docs

* update docs with common explanation file

* updated note info

* fix 1.18 upgrade doc

* fix content-check error

* Update website/content/partials/auto-roll-billing-start-example.mdx

Co-authored-by: miagilepner <mia.epner@hashicorp.com>

---------

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Co-authored-by: miagilepner <mia.epner@hashicorp.com>
@akshya96 akshya96 requested a review from a team as a code owner August 6, 2024 16:59
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Aug 6, 2024

Build Results:
All builds succeeded! ✅

@schavis schavis added the docs label Aug 6, 2024
@akshya96 akshya96 disabled auto-merge August 7, 2024 16:33
@akshya96 akshya96 merged commit d13f360 into release/1.16.x Aug 7, 2024
24 of 26 checks passed
@akshya96 akshya96 deleted the auto-roll-docs-backport-1.16.x branch August 7, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants