-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for new rootless password rotation workflow for DB Static Roles #28374
Merged
vinay-gopalan
merged 10 commits into
main
from
VAULT-27880/rootless-db-pwd-rotation-docs
Oct 7, 2024
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1ea4c1c
add documentation for new rootless password rotation workflow
vinay-gopalan 515c7ce
add capabilities header
vinay-gopalan c55a465
add new section to DB index capabilities
vinay-gopalan c742be9
Make language clearer
vinay-gopalan 428d2cb
revert adding to capabilities page
vinay-gopalan 14fac98
remove not on capabilities
vinay-gopalan 23c9d89
Merge branch 'main' into VAULT-27880/rootless-db-pwd-rotation-docs
schavis e6fa0ad
tweak language
vinay-gopalan 66101ae
Merge branch 'VAULT-27880/rootless-db-pwd-rotation-docs' of github.co…
vinay-gopalan 30f6d09
Merge branch 'main' into VAULT-27880/rootless-db-pwd-rotation-docs
vinay-gopalan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to keep nitpicking this PR, but given we don't have plans to add this to any other DBs anytime soon should we move this to the postgres API specific page?
We could do something similar to how we extend the connection config...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where we should document it depends on where it's defined, not how its use is limited.
If the field is part of the Vault API and recognized as a valid field in a request to the
/database/static-roles/:name
endpoint, we should define it here and note the limited use.If the field is part of the PostgreSQL plugin API and recognized as a valid field in a request to the
/database/config/<postgres_plugin_name>
endpoint (or any other endpoint specific to the plugin), we should define it on the PostgreSQL page.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification, @schavis! This field is part of the Vault API, so I opted to define it here and noted its limited use to select DBs.