Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add copy button for secret path #28629

Merged

Conversation

hellobontempo
Copy link
Contributor

Description

Adds a copy button for secret paths in both kv v2 and v1 secrets engines
Screenshot 2024-10-08 at 10 14 49 AM

Screenshot 2024-10-08 at 10 15 11 AM

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@hellobontempo hellobontempo added this to the 1.16.11 milestone Oct 8, 2024
@hellobontempo hellobontempo requested a review from a team as a code owner October 8, 2024 17:15
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Oct 8, 2024

Build Results:
All builds succeeded! ✅

@hellobontempo
Copy link
Contributor Author

✅ enterprise tests
Screenshot 2024-10-08 at 12 18 07 PM

@@ -35,7 +38,7 @@
{{/if}}

{{#if (or (has-block "toolbarFilters") (has-block "toolbarActions"))}}
<Toolbar aria-label="menu items for managing {{or @mountName @pageTitle}}">
<Toolbar aria-label="menu items for managing {{or @mountName @secretPath @pageTitle}}">
Copy link
Contributor

@Monkeychip Monkeychip Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern here would be, if in the future, someone uses this component with both a secretPath and a pageTitle the behavior would be unexpected. It seems to me that the design of this is that they are mutually exclusive: you can't have both, but only one. I checked the code and that seems to be the case.

Some thoughts:

  1. Create a kv-page-header.js file to have an assertion that you can't have both assigned.
  2. You could just stick with one property but then this else if block doesn't work.
  3. ... 🤔 maybe it's not a concern.

Copy link
Contributor

@Monkeychip Monkeychip Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I like option 1 because it also allows us to add documentation. But you've already gone above and beyond for a simple request so I'll make this comment non-blocking.

Copy link
Contributor Author

@hellobontempo hellobontempo Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for asking about this!

This is just for the aria-label and so it follows the same logic flow for the header above, since they're mutually exclusive and you can only have one header text 😅 . I think the conditional above makes that pretty clear 🤔 I feel like a component and documentation would be overly verbose for such a simple component

Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup and test coverage. A non-blocking comment.

@hellobontempo hellobontempo merged commit 902d853 into main Oct 8, 2024
31 checks passed
@hellobontempo hellobontempo deleted the ui/VAULT-29759/VAULT-29763/add-copy-button-secret-paths branch October 8, 2024 21:06
@hellobontempo hellobontempo removed this from the 1.16.11 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-milestone ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants