Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Ember data upgrade prep: cleanup store and lazyPaginatedQuery #28690

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Oct 11, 2024

Description

Slowly chipping away at cleaning up our manual store. This PR removes stubbed methods unloadAll and unloadRecord which are no longer necessary due to fixes released in ember data 4.12

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@hellobontempo hellobontempo changed the title UI: Cleanup store and lazyPaginatedQuery UI: Ember data upgrade prep: Cleanup store and lazyPaginatedQuery Oct 11, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 11, 2024
@hellobontempo hellobontempo changed the title UI: Ember data upgrade prep: Cleanup store and lazyPaginatedQuery UI: Ember data upgrade prep: cleanup store and lazyPaginatedQuery Oct 11, 2024
Copy link

github-actions bot commented Oct 11, 2024

CI Results:
All Go tests succeeded! ✅

@hellobontempo
Copy link
Contributor Author

✅ enterprise tests
Screenshot 2024-10-11 at 12 12 55 PM

@hellobontempo hellobontempo marked this pull request as ready for review October 11, 2024 19:45
@hellobontempo hellobontempo requested a review from a team as a code owner October 11, 2024 19:45
@hellobontempo hellobontempo added this to the 1.19.0-rc milestone Oct 11, 2024
Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thanks for picking away at this.

@hellobontempo
Copy link
Contributor Author

✅ enterprise passed
Screenshot 2024-10-11 at 1 11 18 PM

@hellobontempo hellobontempo merged commit 217380c into main Oct 11, 2024
31 checks passed
@hellobontempo hellobontempo deleted the ui/cleanup-lazy-paginated-query branch October 11, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants